You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@thrift.apache.org by ge...@apache.org on 2010/07/21 21:14:44 UTC

svn commit: r966369 - in /incubator/thrift/trunk/lib/cocoa/src: protocol/TBinaryProtocol.m server/TSocketServer.m

Author: geechorama
Date: Wed Jul 21 19:14:44 2010
New Revision: 966369

URL: http://svn.apache.org/viewvc?rev=966369&view=rev
Log:
THRIFT-688. Make TBinaryProtocol obey cocoa memory allocation conventions

Modified:
    incubator/thrift/trunk/lib/cocoa/src/protocol/TBinaryProtocol.m
    incubator/thrift/trunk/lib/cocoa/src/server/TSocketServer.m

Modified: incubator/thrift/trunk/lib/cocoa/src/protocol/TBinaryProtocol.m
URL: http://svn.apache.org/viewvc/incubator/thrift/trunk/lib/cocoa/src/protocol/TBinaryProtocol.m?rev=966369&r1=966368&r2=966369&view=diff
==============================================================================
--- incubator/thrift/trunk/lib/cocoa/src/protocol/TBinaryProtocol.m (original)
+++ incubator/thrift/trunk/lib/cocoa/src/protocol/TBinaryProtocol.m Wed Jul 21 19:14:44 2010
@@ -37,7 +37,7 @@ static TBinaryProtocolFactory * gSharedF
 }
 
 - (TBinaryProtocol *) newProtocolOnTransport: (id <TTransport>) transport {
-  return [[[TBinaryProtocol alloc] initWithTransport: transport] autorelease];
+  return [[TBinaryProtocol alloc] initWithTransport: transport];
 }
 
 @end

Modified: incubator/thrift/trunk/lib/cocoa/src/server/TSocketServer.m
URL: http://svn.apache.org/viewvc/incubator/thrift/trunk/lib/cocoa/src/server/TSocketServer.m?rev=966369&r1=966368&r2=966369&view=diff
==============================================================================
--- incubator/thrift/trunk/lib/cocoa/src/server/TSocketServer.m (original)
+++ incubator/thrift/trunk/lib/cocoa/src/server/TSocketServer.m Wed Jul 21 19:14:44 2010
@@ -124,8 +124,8 @@ NSString * const kTSockerServer_Transpor
   TNSFileHandleTransport * transport = [[TNSFileHandleTransport alloc] initWithFileHandle: clientSocket];
   id<TProcessor> processor = [mProcessorFactory processorForTransport: transport];
   
-  id <TProtocol> inProtocol = [mInputProtocolFactory newProtocolOnTransport: transport];
-  id <TProtocol> outProtocol = [mOutputProtocolFactory newProtocolOnTransport: transport];
+  id <TProtocol> inProtocol = [[mInputProtocolFactory newProtocolOnTransport: transport] autorelease];
+  id <TProtocol> outProtocol = [[mOutputProtocolFactory newProtocolOnTransport: transport] autorelease];
 
   @try {
     BOOL result = NO;