You are viewing a plain text version of this content. The canonical link for it is here.

Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2022/12/01 01:38:10 UTC

[GitHub] [kafka] a364176773 commented on a diff in pull request #12898: optimize: -Dcom.sun.management.jmxremote.rmi.port=$JMX_PORT

a364176773 commented on code in PR #12898:
URL: https://github.com/apache/kafka/pull/12898#discussion_r1036609507


##########
bin/kafka-run-class.sh:
##########
@@ -212,7 +212,7 @@ fi
 
 # JMX port to use
 if [  $JMX_PORT ]; then
-  KAFKA_JMX_OPTS="$KAFKA_JMX_OPTS -Dcom.sun.management.jmxremote.port=$JMX_PORT "
+  KAFKA_JMX_OPTS="-Dcom.sun.management.jmxremote.rmi.port=$JMX_PORT $KAFKA_JMX_OPTS -Dcom.sun.management.jmxremote.port=$JMX_PORT "

Review Comment:
   > @C0urante it seems like there is not good answer to that, but for simple properties (like `-D`), the "winner" is the right-most value in the argument list on most JDKs (HotSpot, OpenJ9).
   
   I think so too, so I think it should be a straightforward implementation with a minimum amount of code



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org