[GitHub] DylanVolz commented on a change in pull request #1922: TO golang -- add capability for custom changelog message per object type

[GitBox <gi...@apache.org>]

DylanVolz commented on a change in pull request #1922: TO golang -- add capability for custom changelog message per object type
URL: https://github.com/apache/incubator-trafficcontrol/pull/1922#discussion_r170369800
 
 

 ##########
 File path: traffic_ops/traffic_ops_golang/api/change_log.go
 ##########
 @@ -37,6 +37,10 @@ type ChangeLog struct {
 	LastUpdated tc.Time `json:"lastUpdated" db:"last_updated"`
 }
 
+type Logger interface {
+	ChangeLogMessage(action string, db *sqlx.DB) (string, error)
+}
+
 
 Review comment:
   I agree that Logger should be changed but should conform to the -er pattern.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services