You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@druid.apache.org by GitBox <gi...@apache.org> on 2018/07/09 08:48:56 UTC

[GitHub] asdf2014 opened a new pull request #5980: Various changes about druid-services module

asdf2014 opened a new pull request #5980: Various changes about druid-services module
URL: https://github.com/apache/incubator-druid/pull/5980
 
 
   Various changes about druid-services module:
   
   1. Fix calling to `toArray()` with pre-sized array argument for better performance;
   2. Use lambda to complete the initialization of `Module` / `Runnable` / `Accumulator`;
   3. Remove unuesed import;
   4. Improve if-return clause;
   5. Use `Set#addAll` instead of `for` loop;
   6. Use `Collections.<...>singletonList` instead of `Arrays.<...>asList` for single element situation;
   7. Use `file.toURI().toURL()` instead of `file.toURL()`;
   8. Remove unnecessary unboxing;
   9. Put the string object in front of the equals method;
   10. Use `Collections.<StorageLocationConfig>emptyList()` instead of `Arrays.<StorageLocationConfig>asList()`.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@druid.apache.org
For additional commands, e-mail: dev-help@druid.apache.org