You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@gobblin.apache.org by GitBox <gi...@apache.org> on 2020/09/22 04:43:01 UTC

[GitHub] [incubator-gobblin] arjun4084346 commented on a change in pull request #3109: add metrics field in JobStatus schema

arjun4084346 commented on a change in pull request #3109:
URL: https://github.com/apache/incubator-gobblin/pull/3109#discussion_r492470937



##########
File path: gobblin-runtime/src/main/java/org/apache/gobblin/service/monitoring/JobStatus.java
##########
@@ -40,7 +40,8 @@
   private final long startTime;
   private final long endTime;
   @Setter
-  private String message;
+  private String metrics;

Review comment:
       Actually I added the setter in https://github.com/apache/incubator-gobblin/pull/3076 to add metrics in message field, so it can be set in internal projects. But now I am adding a separate metrics field for that purpose, which is to be set by custom job status retriever.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org