You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "dylanbstorey (via GitHub)" <gi...@apache.org> on 2023/04/22 18:13:50 UTC

[GitHub] [airflow] dylanbstorey opened a new pull request, #30818: fixed some errant strings in the kafka example dags

dylanbstorey opened a new pull request, #30818:
URL: https://github.com/apache/airflow/pull/30818

   Updates to the system tests / example dags for the Apache Kafka provider so that they are functional and useful w/o needing manual intervention when testing for releases. 
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] potiuk merged pull request #30818: fixed some errant strings in the kafka example dags

Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk merged PR #30818:
URL: https://github.com/apache/airflow/pull/30818


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] potiuk commented on pull request #30818: fixed some errant strings in the kafka example dags

Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on PR #30818:
URL: https://github.com/apache/airflow/pull/30818#issuecomment-1518738847

   FYI. @dylanbstorey - speaking of static checks:
   
   ```
   pre-commit install
   ```
   
   And let fixes be applied while commiting or (and)
   
   ```
   breeze static-checks --last-commit
   ```
   
   (after squashing all your commits to one)
   
   Those help with automatically fixing stuff before CI complains  :). 
   
   And yeah, there are cases it does not work when rebasing and things, but usually it does. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org