[GitHub] [airflow] dstandish edited a comment on issue #5112: [AIRFLOW-4209][AIP3-STEP13] Replace imp by importlib

[GitBox <gi...@apache.org>]

dstandish edited a comment on issue #5112: [AIRFLOW-4209][AIP3-STEP13] Replace imp by importlib
URL: https://github.com/apache/airflow/pull/5112#issuecomment-502950705
 
 
   @zhongjiajie i saw there are still failures but not that dagbag one. 
   
   at least on the sqlite build it looked like there were only two fails -- both related to backfill tests because of dag pickling.  the specific error is `can't pickle _thread._local objects`.
   
   i tried using `mod = importlib.machinery.SourceFileLoader(mod_name, filepath).load_module()` around line 198 of `dagbag.py` instead of the `spec` approach, and that resolved the error.  but the[ docs indicate this method `load_module()` is deprecated in 3.6](https://docs.python.org/3/library/importlib.html#importlib.machinery.SourceFileLoader.load_module) so 🤷‍♂   
   
   hopefully that is helpful

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services