You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by GitBox <gi...@apache.org> on 2020/03/16 20:49:12 UTC
[GitHub] [incubator-hudi] bschell opened a new pull request #1413:
[HUDI-539] Add "Config" constructor to HoodieROTablePathFilter
bschell opened a new pull request #1413: [HUDI-539] Add "Config" constructor to HoodieROTablePathFilter
URL: https://github.com/apache/incubator-hudi/pull/1413
Allows HoodieROTablePathFilter to accept a configuration for
initializing the filesystem. This fixes a bug with Presto's use of this
pathfilter. (when combined with the corresponding presto patch)
## *Tips*
- *Thank you very much for contributing to Apache Hudi.*
- *Please review https://hudi.apache.org/contributing.html before opening a pull request.*
## What is the purpose of the pull request
*(For example: This pull request adds quick-start document.)*
## Brief change log
*(for example:)*
- *Modify AnnotationLocation checkstyle rule in checkstyle.xml*
## Verify this pull request
*(Please pick either of the following options)*
This pull request is a trivial rework / code cleanup without any test coverage.
*(or)*
This pull request is already covered by existing tests, such as *(please describe tests)*.
(or)
This change added tests and can be verified as follows:
*(example:)*
- *Added integration tests for end-to-end.*
- *Added HoodieClientWriteTest to verify the change.*
- *Manually verified the change by running a job locally.*
## Committer checklist
- [ ] Has a corresponding JIRA in PR title & commit
- [ ] Commit message is descriptive of the change
- [ ] CI is green
- [ ] Necessary doc changes done or have another open PR
- [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-hudi] vinothchandar commented on issue #1413: [HUDI-539]
Add "Config" constructor to HoodieROTablePathFilter
Posted by GitBox <gi...@apache.org>.
vinothchandar commented on issue #1413: [HUDI-539] Add "Config" constructor to HoodieROTablePathFilter
URL: https://github.com/apache/incubator-hudi/pull/1413#issuecomment-599784095
@bschell HUDI-539 was for fixing this for spark sql.. did you test that as well? does it actually fix anything for spark queries
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-hudi] bschell commented on issue #1413: [HUDI-539] Add
"Config" constructor to HoodieROTablePathFilter
Posted by GitBox <gi...@apache.org>.
bschell commented on issue #1413: [HUDI-539] Add "Config" constructor to HoodieROTablePathFilter
URL: https://github.com/apache/incubator-hudi/pull/1413#issuecomment-599798159
I would need to make the corresponding change in spark to use this new constructor. I haven't seen any issue with Spark's use of the pathfilter so far but I haven't looked closely. I can test this with spark-sql.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-hudi] vinothchandar commented on issue #1413: [HUDI-539]
Add "Config" constructor to HoodieROTablePathFilter
Posted by GitBox <gi...@apache.org>.
vinothchandar commented on issue #1413: [HUDI-539] Add "Config" constructor to HoodieROTablePathFilter
URL: https://github.com/apache/incubator-hudi/pull/1413#issuecomment-599783606
ah... the commit message did not have the HUDI-... prefix.. my bad. clicked too soon
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-hudi] codecov-io commented on issue #1413: [HUDI-539]
Add "Config" constructor to HoodieROTablePathFilter
Posted by GitBox <gi...@apache.org>.
codecov-io commented on issue #1413: [HUDI-539] Add "Config" constructor to HoodieROTablePathFilter
URL: https://github.com/apache/incubator-hudi/pull/1413#issuecomment-599763248
# [Codecov](https://codecov.io/gh/apache/incubator-hudi/pull/1413?src=pr&el=h1) Report
> Merging [#1413](https://codecov.io/gh/apache/incubator-hudi/pull/1413?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-hudi/commit/3ef9e885cacc064fc316c61c7c826f3a1cb96da0?src=pr&el=desc) will **increase** coverage by `0.01%`.
> The diff coverage is `100%`.
[](https://codecov.io/gh/apache/incubator-hudi/pull/1413?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #1413 +/- ##
===========================================
+ Coverage 67.69% 67.7% +0.01%
Complexity 243 243
===========================================
Files 338 338
Lines 16371 16374 +3
Branches 1672 1672
===========================================
+ Hits 11082 11086 +4
Misses 4548 4548
+ Partials 741 740 -1
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-hudi/pull/1413?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...rg/apache/hudi/hadoop/HoodieROTablePathFilter.java](https://codecov.io/gh/apache/incubator-hudi/pull/1413/diff?src=pr&el=tree#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL0hvb2RpZVJPVGFibGVQYXRoRmlsdGVyLmphdmE=) | `64.17% <100%> (+1.67%)` | `0 <0> (ø)` | :arrow_down: |
| [...a/org/apache/hudi/common/util/collection/Pair.java](https://codecov.io/gh/apache/incubator-hudi/pull/1413/diff?src=pr&el=tree#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3V0aWwvY29sbGVjdGlvbi9QYWlyLmphdmE=) | `76% <0%> (+4%)` | `0% <0%> (ø)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-hudi/pull/1413?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-hudi/pull/1413?src=pr&el=footer). Last update [3ef9e88...142c972](https://codecov.io/gh/apache/incubator-hudi/pull/1413?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-hudi] vinothchandar merged pull request #1413:
[HUDI-539] Add "Config" constructor to HoodieROTablePathFilter
Posted by GitBox <gi...@apache.org>.
vinothchandar merged pull request #1413: [HUDI-539] Add "Config" constructor to HoodieROTablePathFilter
URL: https://github.com/apache/incubator-hudi/pull/1413
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services