You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Michael Park <mc...@gmail.com> on 2014/12/31 01:04:46 UTC
Re: Review Request 28698: Modified Resources to account for
reservation type.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28698/
-----------------------------------------------------------
(Updated Dec. 31, 2014, 12:04 a.m.)
Review request for mesos, Adam B, Benjamin Hindman, Ben Mahler, Jie Yu, and Vinod Kone.
Summary (updated)
-----------------
Modified Resources to account for reservation type.
Repository: mesos-git
Description
-------
Modified Resources to account for reservation type.
Diffs
-----
include/mesos/resources.hpp f1517b73def9aff4039f95a89f66208ba1d21c0f
src/common/resources.cpp c17e1791130e7d545bb7cdd54d97d65325d3a69e
Diff: https://reviews.apache.org/r/28698/diff/
Testing
-------
make check
Thanks,
Michael Park
Re: Review Request 28698: Updated Resources to consider
Resource::ReserverType.
Posted by Michael Park <mc...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28698/
-----------------------------------------------------------
(Updated Feb. 19, 2015, 2:55 a.m.)
Review request for mesos, Adam B, Benjamin Hindman, Ben Mahler, Jie Yu, and Vinod Kone.
Repository: mesos
Description
-------
## Overview
With the introduction of `Resource::ReserverType`, the `Resources` object need to consider it in some contexts.
### `static bool Resources::reserved(const Resource &, const ReserverType&);`
Returns true if the given resource is reserved for the given reserverType.
### `Resources::validate`
If `role == `"*"`, then `reserverType` must be `Resource::SLAVE`.
### `Resources::flatten`
`flatten` takes a `Resource::ReserverType` and set the resource with it as well as the role.
### `Resources::find`
We need to prefer resources that match role and ReserverType over resources that only match the role.
### Resources Comparators
`operator==`, `addable`, `subtractable` need to consider `ReserverType`.
Diffs (updated)
-----
include/mesos/resources.hpp c7cc46e0183ea97013dd088a717da6c0e6ed5cf0
src/common/resources.cpp 98371f6873482d0cdbefeb279b58ae6cc680a88f
Diff: https://reviews.apache.org/r/28698/diff/
Testing
-------
make check
Thanks,
Michael Park
Re: Review Request 28698: Updated Resources to consider
Resource::ReserverType.
Posted by Michael Park <mc...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28698/
-----------------------------------------------------------
(Updated Feb. 14, 2015, 12:31 a.m.)
Review request for mesos, Adam B, Benjamin Hindman, Ben Mahler, Jie Yu, and Vinod Kone.
Repository: mesos
Description
-------
## Overview
With the introduction of `Resource::ReserverType`, the `Resources` object need to consider it in some contexts.
### `static bool Resources::reserved(const Resource &, const ReserverType&);`
Returns true if the given resource is reserved for the given reserverType.
### `Resources::validate`
If `role == `"*"`, then `reserverType` must be `Resource::SLAVE`.
### `Resources::flatten`
`flatten` takes a `Resource::ReserverType` and set the resource with it as well as the role.
### `Resources::find`
We need to prefer resources that match role and ReserverType over resources that only match the role.
### Resources Comparators
`operator==`, `addable`, `subtractable` need to consider `ReserverType`.
Diffs (updated)
-----
include/mesos/resources.hpp c7cc46e0183ea97013dd088a717da6c0e6ed5cf0
src/common/resources.cpp 98371f6873482d0cdbefeb279b58ae6cc680a88f
Diff: https://reviews.apache.org/r/28698/diff/
Testing
-------
make check
Thanks,
Michael Park
Re: Review Request 28698: Updated Resources to consider
Resource::ReserverType.
Posted by Michael Park <mc...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28698/
-----------------------------------------------------------
(Updated Feb. 12, 2015, 2:46 a.m.)
Review request for mesos, Adam B, Benjamin Hindman, Ben Mahler, Jie Yu, and Vinod Kone.
Changes
-------
Depends on the new filter abstraction and renaming changes.
Repository: mesos
Description
-------
## Overview
With the introduction of `Resource::ReserverType`, the `Resources` object need to consider it in some contexts.
### `static bool Resources::reserved(const Resource &, const ReserverType&);`
Returns true if the given resource is reserved for the given reserverType.
### `Resources::validate`
If `role == `"*"`, then `reserverType` must be `Resource::SLAVE`.
### `Resources::flatten`
`flatten` takes a `Resource::ReserverType` and set the resource with it as well as the role.
### `Resources::find`
We need to prefer resources that match role and ReserverType over resources that only match the role.
### Resources Comparators
`operator==`, `addable`, `subtractable` need to consider `ReserverType`.
Diffs
-----
include/mesos/resources.hpp c7cc46e0183ea97013dd088a717da6c0e6ed5cf0
src/common/resources.cpp 98371f6873482d0cdbefeb279b58ae6cc680a88f
Diff: https://reviews.apache.org/r/28698/diff/
Testing
-------
make check
Thanks,
Michael Park
Re: Review Request 28698: Updated Resources to consider
Resource::ReserverType.
Posted by Michael Park <mc...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28698/
-----------------------------------------------------------
(Updated Feb. 12, 2015, 1:32 a.m.)
Review request for mesos, Adam B, Benjamin Hindman, Ben Mahler, Jie Yu, and Vinod Kone.
Summary (updated)
-----------------
Updated Resources to consider Resource::ReserverType.
Repository: mesos
Description (updated)
-------
## Overview
With the introduction of `Resource::ReserverType`, the `Resources` object need to consider it in some contexts.
### `static bool Resources::reserved(const Resource &, const ReserverType&);`
Returns true if the given resource is reserved for the given reserverType.
### `Resources::validate`
If `role == `"*"`, then `reserverType` must be `Resource::SLAVE`.
### `Resources::flatten`
`flatten` takes a `Resource::ReserverType` and set the resource with it as well as the role.
### `Resources::find`
We need to prefer resources that match role and ReserverType over resources that only match the role.
### Resources Comparators
`operator==`, `addable`, `subtractable` need to consider `ReserverType`.
Diffs (updated)
-----
include/mesos/resources.hpp c7cc46e0183ea97013dd088a717da6c0e6ed5cf0
src/common/resources.cpp 98371f6873482d0cdbefeb279b58ae6cc680a88f
Diff: https://reviews.apache.org/r/28698/diff/
Testing
-------
make check
Thanks,
Michael Park
Re: Review Request 28698: Modified Resources to account for
reservation type.
Posted by Michael Park <mc...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28698/
-----------------------------------------------------------
(Updated Jan. 29, 2015, 9:16 a.m.)
Review request for mesos, Adam B, Benjamin Hindman, Ben Mahler, Jie Yu, and Vinod Kone.
Repository: mesos-git
Description
-------
Modified Resources to account for reservation type.
Diffs (updated)
-----
include/mesos/resources.hpp 3b57568c10233a0c692787de6464f21af5eaadf4
src/common/resources.cpp 68f64213c47be4700bcb22cd5b76ba6ff616960d
Diff: https://reviews.apache.org/r/28698/diff/
Testing
-------
make check
Thanks,
Michael Park
Re: Review Request 28698: Modified Resources to account for
reservation type.
Posted by Michael Park <mc...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28698/
-----------------------------------------------------------
(Updated Jan. 29, 2015, 5:30 a.m.)
Review request for mesos, Adam B, Benjamin Hindman, Ben Mahler, Jie Yu, and Vinod Kone.
Repository: mesos-git
Description
-------
Modified Resources to account for reservation type.
Diffs (updated)
-----
include/mesos/resources.hpp 3b57568c10233a0c692787de6464f21af5eaadf4
src/common/resources.cpp 68f64213c47be4700bcb22cd5b76ba6ff616960d
Diff: https://reviews.apache.org/r/28698/diff/
Testing
-------
make check
Thanks,
Michael Park
Re: Review Request 28698: Modified Resources to account for
reservation type.
Posted by Michael Park <mc...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28698/
-----------------------------------------------------------
(Updated Jan. 28, 2015, 9:21 a.m.)
Review request for mesos, Adam B, Benjamin Hindman, Ben Mahler, Jie Yu, and Vinod Kone.
Repository: mesos-git
Description
-------
Modified Resources to account for reservation type.
Diffs (updated)
-----
include/mesos/resources.hpp 3b57568c10233a0c692787de6464f21af5eaadf4
src/common/resources.cpp 68f64213c47be4700bcb22cd5b76ba6ff616960d
Diff: https://reviews.apache.org/r/28698/diff/
Testing
-------
make check
Thanks,
Michael Park
Re: Review Request 28698: Modified Resources to account for
reservation type.
Posted by Michael Park <mc...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28698/
-----------------------------------------------------------
(Updated Dec. 31, 2014, 9:52 p.m.)
Review request for mesos, Adam B, Benjamin Hindman, Ben Mahler, Jie Yu, and Vinod Kone.
Repository: mesos-git
Description
-------
Modified Resources to account for reservation type.
Diffs (updated)
-----
include/mesos/resources.hpp f1517b73def9aff4039f95a89f66208ba1d21c0f
src/common/resources.cpp c17e1791130e7d545bb7cdd54d97d65325d3a69e
Diff: https://reviews.apache.org/r/28698/diff/
Testing
-------
make check
Thanks,
Michael Park
Re: Review Request 28698: Modified Resources to account for
reservation type.
Posted by Adam B <ad...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28698/#review66453
-----------------------------------------------------------
Ship it!
LGTM
src/common/resources.cpp
<https://reviews.apache.org/r/28698/#comment110014>
s/Donee/Donut/ or whatever.
- Adam B
On Dec. 30, 2014, 4:04 p.m., Michael Park wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28698/
> -----------------------------------------------------------
>
> (Updated Dec. 30, 2014, 4:04 p.m.)
>
>
> Review request for mesos, Adam B, Benjamin Hindman, Ben Mahler, Jie Yu, and Vinod Kone.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Modified Resources to account for reservation type.
>
>
> Diffs
> -----
>
> include/mesos/resources.hpp f1517b73def9aff4039f95a89f66208ba1d21c0f
> src/common/resources.cpp c17e1791130e7d545bb7cdd54d97d65325d3a69e
>
> Diff: https://reviews.apache.org/r/28698/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Michael Park
>
>