[GitHub] [bookkeeper] nicoloboschi commented on a change in pull request #2944: Fix wrong ledger id parse radix for index relocation file in IndexPersistenceMgr

[GitBox <gi...@apache.org>]

nicoloboschi commented on a change in pull request #2944:
URL: https://github.com/apache/bookkeeper/pull/2944#discussion_r770360041



##########
File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/FileInfo.java
##########
@@ -549,6 +549,7 @@ public synchronized void moveToNewLocation(File newFile, long size) throws IOExc
         }
         fc = new RandomAccessFile(newFile, mode).getChannel();
         lf = newFile;
+        deleted = false;

Review comment:
       it'd be better to have a method `delete(boolean markAsDeleted)` and passing false in this method
   
   in your new code we still have few lines where the `deleted` flag is equals to `true` and it can lead in undefined behaviour




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org