Re: [PR] OpenAPI: Add CatalogObjectIdentifier and CatalogObjectType schemas [iceberg]

["c-thiel (via GitHub)" <gi...@apache.org>]

c-thiel commented on code in PR #16144:
URL: https://github.com/apache/iceberg/pull/16144#discussion_r3183135969


##########
open-api/rest-catalog-open-api.yaml:
##########
@@ -2267,6 +2267,27 @@ components:
           type: string
           nullable: false
 
+    CatalogObjectIdentifier:
+      description:
+        Reference to a catalog object (table, view, or namespace) as an
+        ordered list of hierarchical levels.
+        The object kind is determined by context (e.g. the endpoint or a
+        companion CatalogObjectType discriminator), not by the identifier
+        structure alone.
+      type: array
+      items:
+        type: string
+      example: [ "accounting", "tax", "paid" ]
+
+    CatalogObjectType:
+      type: string
+      description: |
+        The type of a catalog object.
+      enum:
+        - table
+        - view
+        - namespace

Review Comment:
   In the Events Endpoint having this explicit type filter is valuable I believe which is why we introduced this type there.
   Shouldn't clients be tolerant in both cases - for unknown enum variants as well as unknown fields?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org