You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2022/06/01 02:41:01 UTC

[GitHub] [incubator-doris] Kikyou1997 commented on a diff in pull request #9877: [Bug] fix bugs of analyzation of rewrited SQL when triggered the materialized vew

Kikyou1997 commented on code in PR #9877:
URL: https://github.com/apache/incubator-doris/pull/9877#discussion_r886272493


##########
fe/fe-core/src/main/java/org/apache/doris/rewrite/mvrewrite/CountFieldToSum.java:
##########
@@ -81,15 +80,12 @@ public Expr apply(Expr expr, Analyzer analyzer, ExprRewriter.ClauseType clauseTy
         }
 
         // rewrite expr
-        return rewriteExpr(fnChild0, mvColumn, analyzer);
+        return rewriteExpr(mvColumn, analyzer);
     }
 
-    private Expr rewriteExpr(SlotRef queryColumnSlotRef, Column mvColumn, Analyzer analyzer) {
+    private Expr rewriteExpr(Column mvColumn, Analyzer analyzer) {
         Preconditions.checkNotNull(mvColumn);
-        Preconditions.checkNotNull(queryColumnSlotRef);
-        TableName tableName = queryColumnSlotRef.getTableName();
-        Preconditions.checkNotNull(tableName);
-        SlotRef mvSlotRef = new SlotRef(tableName, mvColumn.getName());
+        SlotRef mvSlotRef = new SlotRef(null, mvColumn.getName());

Review Comment:
   done



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org