You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@trafficserver.apache.org by GitBox <gi...@apache.org> on 2021/10/11 23:30:11 UTC
[GitHub] [trafficserver] bneradt opened a new issue #8407: Rename IpEndpoint::port to network_order_port
bneradt opened a new issue #8407:
URL: https://github.com/apache/trafficserver/issues/8407
This issue comes out of the patch to fix a byte ordering bug:
* https://github.com/apache/trafficserver/pull/8406/files
It's easy for a developer to use IpEndpoint::port without thinking explicitly about whether they need network byte order or host byte order versions of the port. In the PR review meeting for #8406, it was suggested that we rename IpEndpoint::port to IpEndpoint:: network_order_port so it would make explicit that byte ordering must be considered.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] ywkaras closed issue #8407: Rename IpEndpoint::port to network_order_port
Posted by GitBox <gi...@apache.org>.
ywkaras closed issue #8407:
URL: https://github.com/apache/trafficserver/issues/8407
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org