[GitHub] [bookkeeper] horizonzy commented on a diff in pull request #3158: support ipv6 address validation

["horizonzy (via GitHub)" <gi...@apache.org>]

horizonzy commented on code in PR #3158:
URL: https://github.com/apache/bookkeeper/pull/3158#discussion_r1166789526


##########
bookkeeper-common/src/main/java/org/apache/bookkeeper/common/net/ServiceURI.java:
##########
@@ -145,6 +146,39 @@ public class ServiceURI {
     public static ServiceURI create(String uriStr) {
         checkNotNull(uriStr, "service uri string is null");
 
+        if (uriStr.contains("[") && uriStr.contains("]")) {

Review Comment:
   Which case does the code cover?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@bookkeeper.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org