You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@jackrabbit.apache.org by "Julian Reschke (JIRA)" <ji...@apache.org> on 2009/07/07 17:40:15 UTC
[jira] Created: (JCR-2192) ItemDefinitionTemplate treats name as
opaque, not a JCR name
ItemDefinitionTemplate treats name as opaque, not a JCR name
------------------------------------------------------------
Key: JCR-2192
URL: https://issues.apache.org/jira/browse/JCR-2192
Project: Jackrabbit Content Repository
Issue Type: Bug
Components: jackrabbit-core
Reporter: Julian Reschke
ItemDefinitionTemplate treats the name as opque string, instead of a JCR Name.
Example: when setting the name to
"{http://example.org/}foo"
then getName() needs to return
"bar:foo"
which the prefix "bar" being mapped to the namesapce "http://example.org/".
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (JCR-2192) handling of expanded-form jcr names by
node type *Template classes
Posted by "angela (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JCR-2192?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
angela updated JCR-2192:
------------------------
Fix Version/s: 2.0.0
> handling of expanded-form jcr names by node type *Template classes
> -------------------------------------------------------------------
>
> Key: JCR-2192
> URL: https://issues.apache.org/jira/browse/JCR-2192
> Project: Jackrabbit Content Repository
> Issue Type: Bug
> Components: jackrabbit-spi-commons, JCR 2.0
> Reporter: Julian Reschke
> Assignee: angela
> Fix For: 2.0.0
>
>
> ItemDefinitionTemplate treats the name as opque string, instead of a JCR Name.
> Example: when setting the name to
> "{http://example.org/}foo"
> then getName() needs to return
> "bar:foo"
> which the prefix "bar" being mapped to the namesapce "http://example.org/".
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (JCR-2192) handling of expanded-form jcr names by
node type *Template classes
Posted by "angela (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JCR-2192?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
angela reassigned JCR-2192:
---------------------------
Assignee: angela
> handling of expanded-form jcr names by node type *Template classes
> -------------------------------------------------------------------
>
> Key: JCR-2192
> URL: https://issues.apache.org/jira/browse/JCR-2192
> Project: Jackrabbit Content Repository
> Issue Type: Bug
> Components: jackrabbit-spi-commons, JCR 2.0
> Reporter: Julian Reschke
> Assignee: angela
>
> ItemDefinitionTemplate treats the name as opque string, instead of a JCR Name.
> Example: when setting the name to
> "{http://example.org/}foo"
> then getName() needs to return
> "bar:foo"
> which the prefix "bar" being mapped to the namesapce "http://example.org/".
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (JCR-2192) handling of expanded-form jcr names by
node type *Template classes
Posted by "Julian Reschke (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JCR-2192?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12729120#action_12729120 ]
Julian Reschke commented on JCR-2192:
-------------------------------------
See related JSR-283 issue: https://jsr-283.dev.java.net/issues/show_bug.cgi?id=794
> handling of expanded-form jcr names by node type *Template classes
> -------------------------------------------------------------------
>
> Key: JCR-2192
> URL: https://issues.apache.org/jira/browse/JCR-2192
> Project: Jackrabbit Content Repository
> Issue Type: Bug
> Components: jackrabbit-spi-commons
> Reporter: Julian Reschke
>
> ItemDefinitionTemplate treats the name as opque string, instead of a JCR Name.
> Example: when setting the name to
> "{http://example.org/}foo"
> then getName() needs to return
> "bar:foo"
> which the prefix "bar" being mapped to the namesapce "http://example.org/".
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (JCR-2192) handling of expanded-form jcr names by
node type *Template classes
Posted by "angela (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JCR-2192?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12735022#action_12735022 ]
angela commented on JCR-2192:
-----------------------------
rev. 797410:
- changed the name handling in the *Template implementations
- added ConstraintViolationException in case of invalid jcr names
BUT: except for the residual item-definition name -> added specially handling
- rechecked the default-values of empty *Templates as defined by the javadoc and adjusted
the code accordingly
- added test-cases for the empty *Template default values
- added some more tests for the various setters
- added test for setting illegal JCR names
- added test for setting residual item def name
- in addition (not mandated by the specification) i added trivial validation for
> RequiredPropertyType
> OPV flag
> since those setters don't allow any exceptions illegalargexp is thrown.
> and added implementation specific test cases.
TODOs:
- The specification doesn't define the default values for a couple of new methods (see 283 issue 798)
- Handling of ValueConstraints needs more clarification (see 794)
- The default values defined for DeclaredSuperTypeNames looked not very consistent to me (see 797)
-> added TODOs both in the TCK tests and in the *TemplateImpl code
> handling of expanded-form jcr names by node type *Template classes
> -------------------------------------------------------------------
>
> Key: JCR-2192
> URL: https://issues.apache.org/jira/browse/JCR-2192
> Project: Jackrabbit Content Repository
> Issue Type: Bug
> Components: jackrabbit-spi-commons, JCR 2.0
> Reporter: Julian Reschke
> Assignee: angela
>
> ItemDefinitionTemplate treats the name as opque string, instead of a JCR Name.
> Example: when setting the name to
> "{http://example.org/}foo"
> then getName() needs to return
> "bar:foo"
> which the prefix "bar" being mapped to the namesapce "http://example.org/".
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (JCR-2192) handling of expanded-form jcr names by
node type *Template classes
Posted by "angela (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JCR-2192?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
angela resolved JCR-2192.
-------------------------
Resolution: Fixed
resolved TODOs related to 283 issues and adjusted tests accordingly
> handling of expanded-form jcr names by node type *Template classes
> -------------------------------------------------------------------
>
> Key: JCR-2192
> URL: https://issues.apache.org/jira/browse/JCR-2192
> Project: Jackrabbit Content Repository
> Issue Type: Bug
> Components: jackrabbit-spi-commons, JCR 2.0
> Reporter: Julian Reschke
> Assignee: angela
>
> ItemDefinitionTemplate treats the name as opque string, instead of a JCR Name.
> Example: when setting the name to
> "{http://example.org/}foo"
> then getName() needs to return
> "bar:foo"
> which the prefix "bar" being mapped to the namesapce "http://example.org/".
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (JCR-2192) handling of expanded-form jcr names by
node type *Template classes
Posted by "angela (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JCR-2192?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12735023#action_12735023 ]
angela commented on JCR-2192:
-----------------------------
Note and 1 more TODO:
It seems to me that we should clean up the spi-commons/nodetype package and try to consolidate the
various impls etc... for the time being i only adjusted the existing classes. this just as a side note...
> handling of expanded-form jcr names by node type *Template classes
> -------------------------------------------------------------------
>
> Key: JCR-2192
> URL: https://issues.apache.org/jira/browse/JCR-2192
> Project: Jackrabbit Content Repository
> Issue Type: Bug
> Components: jackrabbit-spi-commons, JCR 2.0
> Reporter: Julian Reschke
> Assignee: angela
>
> ItemDefinitionTemplate treats the name as opque string, instead of a JCR Name.
> Example: when setting the name to
> "{http://example.org/}foo"
> then getName() needs to return
> "bar:foo"
> which the prefix "bar" being mapped to the namesapce "http://example.org/".
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (JCR-2192) handling of expanded-form jcr names by
node type *Template classes
Posted by "angela (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JCR-2192?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
angela updated JCR-2192:
------------------------
Component/s: JCR 2.0
> handling of expanded-form jcr names by node type *Template classes
> -------------------------------------------------------------------
>
> Key: JCR-2192
> URL: https://issues.apache.org/jira/browse/JCR-2192
> Project: Jackrabbit Content Repository
> Issue Type: Bug
> Components: jackrabbit-spi-commons, JCR 2.0
> Reporter: Julian Reschke
>
> ItemDefinitionTemplate treats the name as opque string, instead of a JCR Name.
> Example: when setting the name to
> "{http://example.org/}foo"
> then getName() needs to return
> "bar:foo"
> which the prefix "bar" being mapped to the namesapce "http://example.org/".
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (JCR-2192) handling of expanded-form jcr names by
node type *Template classes
Posted by "Stefan Guggisberg (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JCR-2192?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Stefan Guggisberg updated JCR-2192:
-----------------------------------
Component/s: (was: jackrabbit-core)
jackrabbit-spi-commons
Summary: handling of expanded-form jcr names by node type *Template classes (was: ItemDefinitionTemplate treats name as opaque, not a JCR name)
not sure whether i agree.
IIRC *Template classes were intended to be simple bean classes with setter/getters, i.e. not necessarily session ns-mapping aware.
however, the following methods would be affected:
package o.a.jackrabbit.spi.commons.nodetype:
AbstractItemDefinitionTemplate#getName()
NodeDefinitionTemplateImpl#getRequiredPrimaryTypeNames()
NodeDefinitionTemplateImpl#getDefaultPrimaryTypeName()
NodeTypeTemplateImpl#getName()
NodeTypeTemplateImpl#getDeclaredSupertypeNames()
NodeTypeTemplateImpl#getPrimaryItemName()
> handling of expanded-form jcr names by node type *Template classes
> -------------------------------------------------------------------
>
> Key: JCR-2192
> URL: https://issues.apache.org/jira/browse/JCR-2192
> Project: Jackrabbit Content Repository
> Issue Type: Bug
> Components: jackrabbit-spi-commons
> Reporter: Julian Reschke
>
> ItemDefinitionTemplate treats the name as opque string, instead of a JCR Name.
> Example: when setting the name to
> "{http://example.org/}foo"
> then getName() needs to return
> "bar:foo"
> which the prefix "bar" being mapped to the namesapce "http://example.org/".
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (JCR-2192) handling of expanded-form jcr names by
node type *Template classes
Posted by "Stefan Guggisberg (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JCR-2192?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12728706#action_12728706 ]
Stefan Guggisberg commented on JCR-2192:
----------------------------------------
> Clarifying: if they are not session-aware, they wouldn't support prefixed names anyway, right?
why not? they would just handle opaque strings.
> handling of expanded-form jcr names by node type *Template classes
> -------------------------------------------------------------------
>
> Key: JCR-2192
> URL: https://issues.apache.org/jira/browse/JCR-2192
> Project: Jackrabbit Content Repository
> Issue Type: Bug
> Components: jackrabbit-spi-commons
> Reporter: Julian Reschke
>
> ItemDefinitionTemplate treats the name as opque string, instead of a JCR Name.
> Example: when setting the name to
> "{http://example.org/}foo"
> then getName() needs to return
> "bar:foo"
> which the prefix "bar" being mapped to the namesapce "http://example.org/".
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (JCR-2192) handling of expanded-form jcr names by
node type *Template classes
Posted by "Julian Reschke (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JCR-2192?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12728702#action_12728702 ]
Julian Reschke commented on JCR-2192:
-------------------------------------
Clarifying: if they are not session-aware, they wouldn't support prefixed names anyway, right?
> handling of expanded-form jcr names by node type *Template classes
> -------------------------------------------------------------------
>
> Key: JCR-2192
> URL: https://issues.apache.org/jira/browse/JCR-2192
> Project: Jackrabbit Content Repository
> Issue Type: Bug
> Components: jackrabbit-spi-commons
> Reporter: Julian Reschke
>
> ItemDefinitionTemplate treats the name as opque string, instead of a JCR Name.
> Example: when setting the name to
> "{http://example.org/}foo"
> then getName() needs to return
> "bar:foo"
> which the prefix "bar" being mapped to the namesapce "http://example.org/".
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (JCR-2192) handling of expanded-form jcr names by
node type *Template classes
Posted by "Julian Reschke (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JCR-2192?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12728711#action_12728711 ]
Julian Reschke commented on JCR-2192:
-------------------------------------
I agree that would work, but then people need to be aware that checking/resolution of the name only occurs upon registration. Will follow up on jsr283 mailing list.
> handling of expanded-form jcr names by node type *Template classes
> -------------------------------------------------------------------
>
> Key: JCR-2192
> URL: https://issues.apache.org/jira/browse/JCR-2192
> Project: Jackrabbit Content Repository
> Issue Type: Bug
> Components: jackrabbit-spi-commons
> Reporter: Julian Reschke
>
> ItemDefinitionTemplate treats the name as opque string, instead of a JCR Name.
> Example: when setting the name to
> "{http://example.org/}foo"
> then getName() needs to return
> "bar:foo"
> which the prefix "bar" being mapped to the namesapce "http://example.org/".
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.