You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dolphinscheduler.apache.org by GitBox <gi...@apache.org> on 2020/09/08 05:09:18 UTC

[GitHub] [incubator-dolphinscheduler] zhuangchong opened a new pull request #3694: [Improvement-3693][ui] definition and instance bulk action buttons show changes

zhuangchong opened a new pull request #3694:
URL: https://github.com/apache/incubator-dolphinscheduler/pull/3694


   ## What is the purpose of the pull request
   #3693
   Change the display state of batch operation buttons in the workflow definition and instance, and click the state when the specific workflow definition or instance is not selected.
   
   ## Brief change log
   
   definition list.vue add button disabled
   instance list.vue add button disabled
   
   ## Verify this pull request
   This change added tests and can be verified as follows:
   
     - *Manually verified the change by testing locally.*
   
   ---
   ##拉取请求的目的是什么
   
   工作流定义和实例中更改批量操作按钮展示状态，不选中具体工作流定义或实例的时候禁止点击状态。
   
   ##简要更改日志
   
   definition list.vue添加按钮已禁用属性
   instance list.vue添加按钮已禁用属性
   
   ##验证此拉取请求
   此更改增加了测试，可以进行如下验证：
      -*通过本地测试手动验证更改。*
   
   ![image](https://user-images.githubusercontent.com/37063904/92435230-651d4800-f1d4-11ea-895f-83cfc38e6410.png)
   ![image](https://user-images.githubusercontent.com/37063904/92435238-69496580-f1d4-11ea-88e8-e04d176c9c41.png)
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-dolphinscheduler] xingchun-chen merged pull request #3694: [Improvement-3693][ui] definition and instance bulk action buttons show changes

Posted by GitBox <gi...@apache.org>.
xingchun-chen merged pull request #3694:
URL: https://github.com/apache/incubator-dolphinscheduler/pull/3694


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-dolphinscheduler] sonarcloud[bot] commented on pull request #3694: [Improvement-3693][ui] definition and instance bulk action buttons show changes

Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] commented on pull request #3694:
URL: https://github.com/apache/incubator-dolphinscheduler/pull/3694#issuecomment-688625233


   Kudos, SonarCloud Quality Gate passed!
   
   [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/bug.png' alt='Bug' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=3694&resolved=false&types=BUG) [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A.png' alt='A' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=3694&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=3694&resolved=false&types=BUG)  
   [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/vulnerability.png' alt='Vulnerability' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=3694&resolved=false&types=VULNERABILITY) [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A.png' alt='A' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=3694&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=3694&resolved=false&types=VULNERABILITY) (and [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/security_hotspot.png' alt='Security Hotspot' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=3694&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/proje
 ct/issues?id=apache-dolphinscheduler&pullRequest=3694&resolved=false&types=SECURITY_HOTSPOT) to review)  
   [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/code_smell.png' alt='Code Smell' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=3694&resolved=false&types=CODE_SMELL) [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A.png' alt='A' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=3694&resolved=false&types=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=3694&resolved=false&types=CODE_SMELL)
   
   [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/CoverageChart/NoCoverageInfo.png' alt='No Coverage information' width='16' height='16' />](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=3694&metric=coverage&view=list) No Coverage information  
   [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/Duplications/3.png' alt='0.0%' width='16' height='16' />](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=3694&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=3694&metric=new_duplicated_lines_density&view=list)
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-dolphinscheduler] zhuangchong commented on pull request #3694: [Improvement-3693][ui] definition and instance bulk action buttons show changes

Posted by GitBox <gi...@apache.org>.
zhuangchong commented on pull request #3694:
URL: https://github.com/apache/incubator-dolphinscheduler/pull/3694#issuecomment-688745465


   @break60 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org