You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@shindig.apache.org by "li xu (JIRA)" <ji...@apache.org> on 2011/04/15 21:36:05 UTC
[jira] [Created] (SHINDIG-1525) Enable shindig to run on non-ROOT
context path
Enable shindig to run on non-ROOT context path
----------------------------------------------
Key: SHINDIG-1525
URL: https://issues.apache.org/jira/browse/SHINDIG-1525
Project: Shindig
Issue Type: Improvement
Components: Java, Javascript
Affects Versions: 3.0.0
Reporter: li xu
Fix For: 3.0.0
Shindig is running on ROOT only today. This patch enables Shindig to run on dynamic context root path without any hardcoded modification to the code.
Test Case:
1. deploy shindig.war with a context root path eg "test"
2. test common container with this url:
http://localhost:8080/test/samplecontainer/examples/commoncontainer/index.jsp
Thanks Mark Nesbitt for the original idea of the patch.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
Re: [jira] [Commented] (SHINDIG-1525) Enable shindig to run on non-ROOT
context path
Posted by Han Nguyen <hn...@us.ibm.com>.
Thanks Henry. Could someone please review this patch? I'd like to have it
in by the end of the week if no objection.
Thank you,
Han
From: Henry Saputra <he...@gmail.com>
To: dev@shindig.apache.org
Date: 04/22/2011 02:21 PM
Subject: Re: [jira] [Commented] (SHINDIG-1525) Enable shindig to
run on non-ROOT context path
I have uploaded the patch to new CR entry with correct SVN repo:
http://codereview.appspot.com/4423064/
- Henry
On Thu, Apr 21, 2011 at 1:34 PM, Han Nguyen <hn...@us.ibm.com> wrote:
> Li is out of office this week, she's returning next Monday. Is there a
way
> to add additional editor on code review going forward?
> Han
>
>
>
> From: Henry Saputra <he...@gmail.com>
> To: dev@shindig.apache.org
> Date: 04/21/2011 02:30 PM
> Subject: Re: [jira] [Commented] (SHINDIG-1525) Enable shindig to
> run on non-ROOT context path
>
>
>
> Could you change the repo svn from
> http://svn.apache.org/repos/asf/incubator/shindig/trunk/ to
> http://svn.apache.org/repos/asf/shindig/trunk/
>
> - Henry
>
> On Fri, Apr 15, 2011 at 3:11 PM, li xu (JIRA) <ji...@apache.org> wrote:
>>
>> [
>
https://issues.apache.org/jira/browse/SHINDIG-1525?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13020452#comment-13020452
> ]
>>
>> li xu commented on SHINDIG-1525:
>> --------------------------------
>>
>> yes, it's uploaded here: http://codereview.appspot.com/4430047/
>> thanks.
>>
>>> Enable shindig to run on non-ROOT context path
>>> ----------------------------------------------
>>>
>>> Key: SHINDIG-1525
>>> URL:
https://issues.apache.org/jira/browse/SHINDIG-1525
>>> Project: Shindig
>>> Issue Type: Improvement
>>> Components: Java, Javascript
>>> Affects Versions: 3.0.0
>>> Reporter: li xu
>>> Labels: patch
>>> Fix For: 3.0.0
>>>
>>> Attachments: contextRoot415.patch
>>>
>>> Original Estimate: 336h
>>> Remaining Estimate: 336h
>>>
>>> Shindig is running on ROOT only today. This patch enables Shindig to
> run on dynamic context root path without any hardcoded modification to
the
> code.
>>> Test Case:
>>> 1. deploy shindig.war with a context root path eg "test"
>>> 2. test common container with this url:
>>>
>
http://localhost:8080/test/samplecontainer/examples/commoncontainer/index.jsp
>
>>> Thanks Mark Nesbitt for the original idea of the patch.
>>
>> --
>> This message is automatically generated by JIRA.
>> For more information on JIRA, see:
> http://www.atlassian.com/software/jira
>>
>
>
>
> --
> Thanks,
> Henry
>
>
>
--
Thanks,
Henry
Re: [jira] [Commented] (SHINDIG-1525) Enable shindig to run on
non-ROOT context path
Posted by Henry Saputra <he...@gmail.com>.
I have uploaded the patch to new CR entry with correct SVN repo:
http://codereview.appspot.com/4423064/
- Henry
On Thu, Apr 21, 2011 at 1:34 PM, Han Nguyen <hn...@us.ibm.com> wrote:
> Li is out of office this week, she's returning next Monday. Is there a way
> to add additional editor on code review going forward?
> Han
>
>
>
> From: Henry Saputra <he...@gmail.com>
> To: dev@shindig.apache.org
> Date: 04/21/2011 02:30 PM
> Subject: Re: [jira] [Commented] (SHINDIG-1525) Enable shindig to
> run on non-ROOT context path
>
>
>
> Could you change the repo svn from
> http://svn.apache.org/repos/asf/incubator/shindig/trunk/ to
> http://svn.apache.org/repos/asf/shindig/trunk/
>
> - Henry
>
> On Fri, Apr 15, 2011 at 3:11 PM, li xu (JIRA) <ji...@apache.org> wrote:
>>
>> [
> https://issues.apache.org/jira/browse/SHINDIG-1525?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13020452#comment-13020452
> ]
>>
>> li xu commented on SHINDIG-1525:
>> --------------------------------
>>
>> yes, it's uploaded here: http://codereview.appspot.com/4430047/
>> thanks.
>>
>>> Enable shindig to run on non-ROOT context path
>>> ----------------------------------------------
>>>
>>> Key: SHINDIG-1525
>>> URL: https://issues.apache.org/jira/browse/SHINDIG-1525
>>> Project: Shindig
>>> Issue Type: Improvement
>>> Components: Java, Javascript
>>> Affects Versions: 3.0.0
>>> Reporter: li xu
>>> Labels: patch
>>> Fix For: 3.0.0
>>>
>>> Attachments: contextRoot415.patch
>>>
>>> Original Estimate: 336h
>>> Remaining Estimate: 336h
>>>
>>> Shindig is running on ROOT only today. This patch enables Shindig to
> run on dynamic context root path without any hardcoded modification to the
> code.
>>> Test Case:
>>> 1. deploy shindig.war with a context root path eg "test"
>>> 2. test common container with this url:
>>>
> http://localhost:8080/test/samplecontainer/examples/commoncontainer/index.jsp
>
>>> Thanks Mark Nesbitt for the original idea of the patch.
>>
>> --
>> This message is automatically generated by JIRA.
>> For more information on JIRA, see:
> http://www.atlassian.com/software/jira
>>
>
>
>
> --
> Thanks,
> Henry
>
>
>
--
Thanks,
Henry
Re: [jira] [Commented] (SHINDIG-1525) Enable shindig to run on non-ROOT
context path
Posted by Han Nguyen <hn...@us.ibm.com>.
Li is out of office this week, she's returning next Monday. Is there a way
to add additional editor on code review going forward?
Han
From: Henry Saputra <he...@gmail.com>
To: dev@shindig.apache.org
Date: 04/21/2011 02:30 PM
Subject: Re: [jira] [Commented] (SHINDIG-1525) Enable shindig to
run on non-ROOT context path
Could you change the repo svn from
http://svn.apache.org/repos/asf/incubator/shindig/trunk/ to
http://svn.apache.org/repos/asf/shindig/trunk/
- Henry
On Fri, Apr 15, 2011 at 3:11 PM, li xu (JIRA) <ji...@apache.org> wrote:
>
> [
https://issues.apache.org/jira/browse/SHINDIG-1525?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13020452#comment-13020452
]
>
> li xu commented on SHINDIG-1525:
> --------------------------------
>
> yes, it's uploaded here: http://codereview.appspot.com/4430047/
> thanks.
>
>> Enable shindig to run on non-ROOT context path
>> ----------------------------------------------
>>
>> Key: SHINDIG-1525
>> URL: https://issues.apache.org/jira/browse/SHINDIG-1525
>> Project: Shindig
>> Issue Type: Improvement
>> Components: Java, Javascript
>> Affects Versions: 3.0.0
>> Reporter: li xu
>> Labels: patch
>> Fix For: 3.0.0
>>
>> Attachments: contextRoot415.patch
>>
>> Original Estimate: 336h
>> Remaining Estimate: 336h
>>
>> Shindig is running on ROOT only today. This patch enables Shindig to
run on dynamic context root path without any hardcoded modification to the
code.
>> Test Case:
>> 1. deploy shindig.war with a context root path eg "test"
>> 2. test common container with this url:
>>
http://localhost:8080/test/samplecontainer/examples/commoncontainer/index.jsp
>> Thanks Mark Nesbitt for the original idea of the patch.
>
> --
> This message is automatically generated by JIRA.
> For more information on JIRA, see:
http://www.atlassian.com/software/jira
>
--
Thanks,
Henry
Re: [jira] [Commented] (SHINDIG-1525) Enable shindig to run on
non-ROOT context path
Posted by Henry Saputra <he...@gmail.com>.
Could you change the repo svn from
http://svn.apache.org/repos/asf/incubator/shindig/trunk/ to
http://svn.apache.org/repos/asf/shindig/trunk/
- Henry
On Fri, Apr 15, 2011 at 3:11 PM, li xu (JIRA) <ji...@apache.org> wrote:
>
> [ https://issues.apache.org/jira/browse/SHINDIG-1525?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13020452#comment-13020452 ]
>
> li xu commented on SHINDIG-1525:
> --------------------------------
>
> yes, it's uploaded here: http://codereview.appspot.com/4430047/
> thanks.
>
>> Enable shindig to run on non-ROOT context path
>> ----------------------------------------------
>>
>> Key: SHINDIG-1525
>> URL: https://issues.apache.org/jira/browse/SHINDIG-1525
>> Project: Shindig
>> Issue Type: Improvement
>> Components: Java, Javascript
>> Affects Versions: 3.0.0
>> Reporter: li xu
>> Labels: patch
>> Fix For: 3.0.0
>>
>> Attachments: contextRoot415.patch
>>
>> Original Estimate: 336h
>> Remaining Estimate: 336h
>>
>> Shindig is running on ROOT only today. This patch enables Shindig to run on dynamic context root path without any hardcoded modification to the code.
>> Test Case:
>> 1. deploy shindig.war with a context root path eg "test"
>> 2. test common container with this url:
>> http://localhost:8080/test/samplecontainer/examples/commoncontainer/index.jsp
>> Thanks Mark Nesbitt for the original idea of the patch.
>
> --
> This message is automatically generated by JIRA.
> For more information on JIRA, see: http://www.atlassian.com/software/jira
>
--
Thanks,
Henry
[jira] [Closed] (SHINDIG-1525) Enable shindig to run on non-ROOT
context path
Posted by "Paul Lindner (Closed) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-1525?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Paul Lindner closed SHINDIG-1525.
---------------------------------
part of 2.5.0-beta1 release.
> Enable shindig to run on non-ROOT context path
> ----------------------------------------------
>
> Key: SHINDIG-1525
> URL: https://issues.apache.org/jira/browse/SHINDIG-1525
> Project: Shindig
> Issue Type: Improvement
> Components: Java, Javascript
> Affects Versions: 2.5.0-beta1
> Reporter: li xu
> Labels: patch
> Fix For: 2.5.0-beta1
>
> Attachments: contextRoot415.patch
>
> Original Estimate: 336h
> Remaining Estimate: 336h
>
> Shindig is running on ROOT only today. This patch enables Shindig to run on dynamic context root path without any hardcoded modification to the code.
> Test Case:
> 1. deploy shindig.war with a context root path eg "test"
> 2. test common container with this url:
> http://localhost:8080/test/samplecontainer/examples/commoncontainer/index.jsp
> Thanks Mark Nesbitt for the original idea of the patch.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (SHINDIG-1525) Enable shindig to run on non-ROOT
context path
Posted by "li xu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-1525?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
li xu updated SHINDIG-1525:
---------------------------
Attachment: contextRoot415.patch
> Enable shindig to run on non-ROOT context path
> ----------------------------------------------
>
> Key: SHINDIG-1525
> URL: https://issues.apache.org/jira/browse/SHINDIG-1525
> Project: Shindig
> Issue Type: Improvement
> Components: Java, Javascript
> Affects Versions: 3.0.0
> Reporter: li xu
> Labels: patch
> Fix For: 3.0.0
>
> Attachments: contextRoot415.patch
>
> Original Estimate: 336h
> Remaining Estimate: 336h
>
> Shindig is running on ROOT only today. This patch enables Shindig to run on dynamic context root path without any hardcoded modification to the code.
> Test Case:
> 1. deploy shindig.war with a context root path eg "test"
> 2. test common container with this url:
> http://localhost:8080/test/samplecontainer/examples/commoncontainer/index.jsp
> Thanks Mark Nesbitt for the original idea of the patch.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (SHINDIG-1525) Enable shindig to run on non-ROOT
context path
Posted by "li xu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-1525?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13031866#comment-13031866 ]
li xu commented on SHINDIG-1525:
--------------------------------
Patch is updated based on comments, please review
http://codereview.appspot.com/4430047/
> Enable shindig to run on non-ROOT context path
> ----------------------------------------------
>
> Key: SHINDIG-1525
> URL: https://issues.apache.org/jira/browse/SHINDIG-1525
> Project: Shindig
> Issue Type: Improvement
> Components: Java, Javascript
> Affects Versions: 3.0.0
> Reporter: li xu
> Labels: patch
> Fix For: 3.0.0
>
> Attachments: contextRoot415.patch
>
> Original Estimate: 336h
> Remaining Estimate: 336h
>
> Shindig is running on ROOT only today. This patch enables Shindig to run on dynamic context root path without any hardcoded modification to the code.
> Test Case:
> 1. deploy shindig.war with a context root path eg "test"
> 2. test common container with this url:
> http://localhost:8080/test/samplecontainer/examples/commoncontainer/index.jsp
> Thanks Mark Nesbitt for the original idea of the patch.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (SHINDIG-1525) Enable shindig to run on non-ROOT
context path
Posted by "li xu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-1525?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13020452#comment-13020452 ]
li xu commented on SHINDIG-1525:
--------------------------------
yes, it's uploaded here: http://codereview.appspot.com/4430047/
thanks.
> Enable shindig to run on non-ROOT context path
> ----------------------------------------------
>
> Key: SHINDIG-1525
> URL: https://issues.apache.org/jira/browse/SHINDIG-1525
> Project: Shindig
> Issue Type: Improvement
> Components: Java, Javascript
> Affects Versions: 3.0.0
> Reporter: li xu
> Labels: patch
> Fix For: 3.0.0
>
> Attachments: contextRoot415.patch
>
> Original Estimate: 336h
> Remaining Estimate: 336h
>
> Shindig is running on ROOT only today. This patch enables Shindig to run on dynamic context root path without any hardcoded modification to the code.
> Test Case:
> 1. deploy shindig.war with a context root path eg "test"
> 2. test common container with this url:
> http://localhost:8080/test/samplecontainer/examples/commoncontainer/index.jsp
> Thanks Mark Nesbitt for the original idea of the patch.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (SHINDIG-1525) Enable shindig to run on non-ROOT
context path
Posted by "Henry Saputra (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-1525?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13020421#comment-13020421 ]
Henry Saputra commented on SHINDIG-1525:
----------------------------------------
Would you mind uploading your patch to http://codereview.appspot.com/ for code review?
You can add dev-remailer@shindig.apache.org as reviewer.
Thanks.
> Enable shindig to run on non-ROOT context path
> ----------------------------------------------
>
> Key: SHINDIG-1525
> URL: https://issues.apache.org/jira/browse/SHINDIG-1525
> Project: Shindig
> Issue Type: Improvement
> Components: Java, Javascript
> Affects Versions: 3.0.0
> Reporter: li xu
> Labels: patch
> Fix For: 3.0.0
>
> Attachments: contextRoot415.patch
>
> Original Estimate: 336h
> Remaining Estimate: 336h
>
> Shindig is running on ROOT only today. This patch enables Shindig to run on dynamic context root path without any hardcoded modification to the code.
> Test Case:
> 1. deploy shindig.war with a context root path eg "test"
> 2. test common container with this url:
> http://localhost:8080/test/samplecontainer/examples/commoncontainer/index.jsp
> Thanks Mark Nesbitt for the original idea of the patch.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (SHINDIG-1525) Enable shindig to run on non-ROOT
context path
Posted by "li xu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-1525?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13035031#comment-13035031 ]
li xu commented on SHINDIG-1525:
--------------------------------
A new patch is uploaded. Please review.
It has been a while, please help move forward. thanks.
List of things addressed with the patch...
1. support context path other than root
related updates to common container
related updates to shindig container
2. addressed all the comments received so far
3. test passed
> Enable shindig to run on non-ROOT context path
> ----------------------------------------------
>
> Key: SHINDIG-1525
> URL: https://issues.apache.org/jira/browse/SHINDIG-1525
> Project: Shindig
> Issue Type: Improvement
> Components: Java, Javascript
> Affects Versions: 3.0.0
> Reporter: li xu
> Labels: patch
> Fix For: 3.0.0
>
> Attachments: contextRoot415.patch
>
> Original Estimate: 336h
> Remaining Estimate: 336h
>
> Shindig is running on ROOT only today. This patch enables Shindig to run on dynamic context root path without any hardcoded modification to the code.
> Test Case:
> 1. deploy shindig.war with a context root path eg "test"
> 2. test common container with this url:
> http://localhost:8080/test/samplecontainer/examples/commoncontainer/index.jsp
> Thanks Mark Nesbitt for the original idea of the patch.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (SHINDIG-1525) Enable shindig to run on non-ROOT
context path
Posted by "Henry Saputra (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-1525?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13023317#comment-13023317 ]
Henry Saputra commented on SHINDIG-1525:
----------------------------------------
Upload new CR to fix the Shindig svn base:
http://codereview.appspot.com/4423064/
> Enable shindig to run on non-ROOT context path
> ----------------------------------------------
>
> Key: SHINDIG-1525
> URL: https://issues.apache.org/jira/browse/SHINDIG-1525
> Project: Shindig
> Issue Type: Improvement
> Components: Java, Javascript
> Affects Versions: 3.0.0
> Reporter: li xu
> Labels: patch
> Fix For: 3.0.0
>
> Attachments: contextRoot415.patch
>
> Original Estimate: 336h
> Remaining Estimate: 336h
>
> Shindig is running on ROOT only today. This patch enables Shindig to run on dynamic context root path without any hardcoded modification to the code.
> Test Case:
> 1. deploy shindig.war with a context root path eg "test"
> 2. test common container with this url:
> http://localhost:8080/test/samplecontainer/examples/commoncontainer/index.jsp
> Thanks Mark Nesbitt for the original idea of the patch.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (SHINDIG-1525) Enable shindig to run on non-ROOT
context path
Posted by "li xu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-1525?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
li xu resolved SHINDIG-1525.
----------------------------
Resolution: Fixed
> Enable shindig to run on non-ROOT context path
> ----------------------------------------------
>
> Key: SHINDIG-1525
> URL: https://issues.apache.org/jira/browse/SHINDIG-1525
> Project: Shindig
> Issue Type: Improvement
> Components: Java, Javascript
> Affects Versions: 3.0.0
> Reporter: li xu
> Labels: patch
> Fix For: 3.0.0
>
> Attachments: contextRoot415.patch
>
> Original Estimate: 336h
> Remaining Estimate: 336h
>
> Shindig is running on ROOT only today. This patch enables Shindig to run on dynamic context root path without any hardcoded modification to the code.
> Test Case:
> 1. deploy shindig.war with a context root path eg "test"
> 2. test common container with this url:
> http://localhost:8080/test/samplecontainer/examples/commoncontainer/index.jsp
> Thanks Mark Nesbitt for the original idea of the patch.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira