You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@kylin.apache.org by GitBox <gi...@apache.org> on 2019/03/22 14:17:58 UTC

[GitHub] [kylin] shaofengshi commented on issue #538: KYLIN-3898 Cube level properties are ineffective in the some build steps

shaofengshi commented on issue #538: KYLIN-3898 Cube level properties are ineffective in the some build steps
URL: https://github.com/apache/kylin/pull/538#issuecomment-475638101
 
 
   Hi Temple, I think the more clear way is in :
   
   org.apache.kylin.job.JoinedFlatTable#generateCreateTableStatement(org.apache.kylin.metadata.model.IJoinedFlatTableDesc, java.lang.String)
   
   Change ` String storageFormat = flatDesc.getDataModel().getConfig().getFlatTableStorageFormat();`
   
   to 
   ` String storageFormat = flatDesc.getSegment().getConfig().getFlatTableStorageFormat();`
   
   Which is to say, here using segment level config (which is also the cube level) is better than the model level config. Just let me know your idea.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services