[jira] [Commented] (CLOUDSTACK-10160) KVM VirtIO-SCSI not defined properly in Libvirt XML

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/CLOUDSTACK-10160?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16266703#comment-16266703 ] 

ASF GitHub Bot commented on CLOUDSTACK-10160:
---------------------------------------------

wido opened a new pull request #2341: CLOUDSTACK-10160: Fix typo in Libvirt XML definition for Virtio-SCSI
URL: https://github.com/apache/cloudstack/pull/2341
 
 
   The attribute for the XML element 'controller' should be 'model' and
   not 'mode'.
   
   Source: https://libvirt.org/formatdomain.html#elementsControllers
   
     A scsi controller has an optional attribute model, which is one of
     'auto', 'buslogic', 'ibmvscsi', 'lsilogic', 'lsisas1068', 'lsisas1078',
     'virtio-scsi' or 'vmpvscsi'.
   
   In the current state a regular SCSI device is attached and not a Virtio-SCSI
   device.
   
   Afterwards this is what *lspci* reports:
   
   <pre>
   root@ub-scsi:~# lspci |grep -i scsi
   00:09.0 SCSI storage controller: Red Hat, Inc Virtio SCSI
   root@ub-scsi:~# 
   </pre>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> KVM VirtIO-SCSI not defined properly in Libvirt XML
> ---------------------------------------------------
>
>                 Key: CLOUDSTACK-10160
>                 URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10160
>             Project: CloudStack
>          Issue Type: Bug
>      Security Level: Public(Anyone can view this level - this is the default.) 
>    Affects Versions: 4.10.0.0
>            Reporter: Wido den Hollander
>            Assignee: Wido den Hollander
>             Fix For: Future
>
>
> The XML for defining Virtio-SCSI has a typo:
> It defines:
> *<controller type='scsi' index='0' mode='virtio-scsi'>*
> But this should be
> *<controller type='scsi' index='0' model='virtio-scsi'/>*
> Sources:
> - https://libvirt.org/formatdomain.html#elementsControllers
> - https://www.redhat.com/archives/libvirt-users/2014-February/msg00011.html
> A scsi controller has an optional attribute model, which is one of 'auto', 'buslogic', 'ibmvscsi', 'lsilogic', 'lsisas1068', 'lsisas1078', 'virtio-scsi' or 'vmpvscsi'.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)