You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/03/12 10:16:52 UTC

[GitHub] [airflow] mcepok commented on a change in pull request #14740: Don't exit upgrade_check with code 1 if there are no problems

mcepok commented on a change in pull request #14740:
URL: https://github.com/apache/airflow/pull/14740#discussion_r593060708



##########
File path: airflow/upgrade/checker.py
##########
@@ -115,8 +115,9 @@ def run(args):
     # We want to show only output of upgrade_check command
     logging.disable(logging.ERROR)
 
-    all_problems = check_upgrade(formatter, rules)
-    if all_problems:
+    all_rule_statuses = check_upgrade(formatter, rules)
+    any_problems = any([rule.is_problem for rule in all_rule_statuses])

Review comment:
       :+1: 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org