You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cordova.apache.org by GitBox <gi...@apache.org> on 2019/10/03 14:50:11 UTC
[GitHub] [cordova-ios] mobidev111 opened a new issue #681: Add iPhone XR &
iPhone XS Max splashscreens
mobidev111 opened a new issue #681: Add iPhone XR & iPhone XS Max splashscreens
URL: https://github.com/apache/cordova-ios/issues/681
# Bug Report
## Problem
### What is expected to happen?
iPhone XR & iPhone XS Max splashscreens do get copied over if specified in config.xml
### What does actually happen?
Images don't get copied
root cause: prepare.js doesn't include the new splash screen dimensions
## Solution
### Extend prepare.js
`https://github.com/apache/cordova-ios/blob/master/bin/templates/scripts/cordova/lib/prepare.js#L428`
```javascript
- { dest: 'Default-Landscape-2436h.png', width: 2436, height: 1125 }
+ { dest: 'Default-Landscape-2436h.png', width: 2436, height: 1125 },
+ { dest: 'Default-1792h.png', width: 828, height: 1792 },
+ { dest: 'Default-Landscape-1792h.png', width: 1792, height: 828 },
+ { dest: 'Default-2688h.png', width: 1242, height: 2688 },
+ { dest: 'Default-Landscape-2688h.png', width: 2688, height: 1242 }
```
### Extend config.xml
```xml
+ <splash height="828" src="res/screen/ios/Default-Landscape-1792h.png" width="1792" />
+ <splash height="1792" src="res/screen/ios/Default-1792h.png" width="828" />
+ <splash height="2688" src="res/screen/ios/Default-2688h.png" width="1242" />
+ <splash height="1242" src="res/screen/ios/Default-Landscape-2688h.png" width="2688" />
```
### In the generated project: Extend Contents.json
platforms/ios/AirSec/Images.xcassets/LaunchImage.launchimage/Contents.json
```json
{
"orientation": "portrait",
"idiom": "iphone",
"extent": "full-screen",
"filename": "Default-2688h.png",
"minimum-system-version": "12.0",
"subtype": "2688h",
"scale": "3x"
},
{
"orientation": "landscape",
"idiom": "iphone",
"extent": "full-screen",
"filename": "Default-Landscape-2688h.png",
"minimum-system-version": "12.0",
"subtype": "2688h",
"scale": "3x"
},
{
"orientation": "portrait",
"idiom": "iphone",
"extent": "full-screen",
"filename": "Default-1792h.png",
"minimum-system-version": "12.0",
"subtype": "1792h",
"scale": "2x"
},
{
"orientation": "landscape",
"idiom": "iphone",
"extent": "full-screen",
"filename": "Default-Landscape-1792h.png",
"minimum-system-version": "12.0",
"subtype": "1792h",
"scale": "2x"
},
```
## Checklist
<!-- Please check the boxes by putting an x in the [ ] like so: [x] -->
- [X] I searched for existing GitHub issues
- [X] I updated all Cordova tooling to most recent version
- [X] I included all the necessary information above
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org