You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2020/07/23 14:31:51 UTC
[GitHub] [incubator-apisix-dashboard] TikWind opened a new pull request #337: feat(i18n): other module
TikWind opened a new pull request #337:
URL: https://github.com/apache/incubator-apisix-dashboard/pull/337
i18n other module
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-apisix-dashboard] juzhiyuan commented on a change in pull request #337: feat(i18n): other module
Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on a change in pull request #337:
URL: https://github.com/apache/incubator-apisix-dashboard/pull/337#discussion_r459867327
##########
File path: src/services/user.ts
##########
@@ -8,8 +9,11 @@ export async function query() {
}
export async function queryCurrent(): Promise<API.CurrentUser> {
+
Review comment:
Because useIntl is a hook, and hook could only be executed in Redux Function Component.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-apisix-dashboard] juzhiyuan commented on a change in pull request #337: feat(i18n): other module
Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on a change in pull request #337:
URL: https://github.com/apache/incubator-apisix-dashboard/pull/337#discussion_r459867213
##########
File path: src/services/user.ts
##########
@@ -8,8 +9,11 @@ export async function query() {
}
export async function queryCurrent(): Promise<API.CurrentUser> {
+
Review comment:
I think there will have an error...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org