You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2020/09/24 10:13:15 UTC

[GitHub] [kafka] ijuma opened a new pull request #9336: MINOR: Don't publish javadocs for raft module

ijuma opened a new pull request #9336:
URL: https://github.com/apache/kafka/pull/9336


   ### Committer Checklist (excluded from commit message)
   - [ ] Verify design and implementation 
   - [ ] Verify test coverage and CI build status
   - [ ] Verify documentation (including upgrade notes)
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] hachikuji commented on pull request #9336: MINOR: Don't publish javadocs for raft module

Posted by GitBox <gi...@apache.org>.
hachikuji commented on pull request #9336:
URL: https://github.com/apache/kafka/pull/9336#issuecomment-704519950


   @ijuma Thanks, LGTM. I think we can consider exposing an API eventually, but for now I'd like to have full flexibility to change it.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] ijuma commented on pull request #9336: MINOR: Don't publish javadocs for raft module

Posted by GitBox <gi...@apache.org>.
ijuma commented on pull request #9336:
URL: https://github.com/apache/kafka/pull/9336#issuecomment-698252529


   @hachikuji Do we intend to various non internal Raft classes to be a public API where we need a KIP to make any changes? If we don't want that or not yet, we should consider merging this PR.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] ijuma merged pull request #9336: MINOR: Don't publish javadocs for raft module

Posted by GitBox <gi...@apache.org>.
ijuma merged pull request #9336:
URL: https://github.com/apache/kafka/pull/9336


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] ijuma edited a comment on pull request #9336: MINOR: Don't publish javadocs for raft module

Posted by GitBox <gi...@apache.org>.
ijuma edited a comment on pull request #9336:
URL: https://github.com/apache/kafka/pull/9336#issuecomment-698252529


   @hachikuji Do we intend the various non internal Raft classes to be a public API where we need a KIP to make any changes? If we don't want that or not yet, we should consider merging this PR.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] ijuma edited a comment on pull request #9336: MINOR: Don't publish javadocs for raft module

Posted by GitBox <gi...@apache.org>.
ijuma edited a comment on pull request #9336:
URL: https://github.com/apache/kafka/pull/9336#issuecomment-698252529


   @hachikuji Do we intend the various non internal Raft classes to be a public API where we need a KIP to make any changes? If we don't want that or not yet, we should consider merging this PR.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] ijuma commented on pull request #9336: MINOR: Don't publish javadocs for raft module

Posted by GitBox <gi...@apache.org>.
ijuma commented on pull request #9336:
URL: https://github.com/apache/kafka/pull/9336#issuecomment-704521581


   Sounds good.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] ijuma commented on pull request #9336: MINOR: Don't publish javadocs for raft module

Posted by GitBox <gi...@apache.org>.
ijuma commented on pull request #9336:
URL: https://github.com/apache/kafka/pull/9336#issuecomment-698252529


   @hachikuji Do we intend to various non internal Raft classes to be a public API where we need a KIP to make any changes? If we don't want that or not yet, we should consider merging this PR.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org