[GitHub] [commons-math] sebbASF commented on pull request #233: new method that takes string and extracts list of numbers

["sebbASF (via GitHub)" <gi...@apache.org>]

sebbASF commented on PR #233:
URL: https://github.com/apache/commons-math/pull/233#issuecomment-1616856138

   I'm not convinced that the method is appropriate for a Commons component.
   Seems to me any such parsing really needs to be designed for the context in which it is to be used.
   
   Also, as it stands, the proposed method depends on the representation of the decimal point. It also does not allow for thousands separators, and will match numbers with leading or trailing text (e.g. G7, 3G). It also does not allow for large integer numbers beyond the range of Double.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org