[GitHub] [incubator-iceberg] rdblue edited a comment on issue #349: Remove unreferenced hash computations

[GitBox <gi...@apache.org>]

rdblue edited a comment on issue #349: Remove unreferenced hash computations
URL: https://github.com/apache/incubator-iceberg/pull/349#issuecomment-524581190
 
 
   I'm reluctant to completely remove these in case there is some legitimate reason to hash values in the future that requires specification. I'm concerned if we did this a second time, I would forget that the hash values for equivalent floats and doubles are the same to support type promotion.
   
   Instead of removing these entirely, what about moving them to a separate table with a note? "Boolean, float, and double values are NOT valid types for bucketing, but in the event that the values should be hashed, the above hash function must be applied as in the following table."

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org