[jira] [Created] (HDFS-4815) Double call countReplicas() to fetch corruptReplicas and liveReplicas is not needed

["Tian Hong Wang (JIRA)" <ji...@apache.org>]

Tian Hong Wang created HDFS-4815:
------------------------------------

             Summary: Double call countReplicas() to fetch corruptReplicas and liveReplicas is not needed
                 Key: HDFS-4815
                 URL: https://issues.apache.org/jira/browse/HDFS-4815
             Project: Hadoop HDFS
          Issue Type: Bug
            Reporter: Tian Hong Wang
            Assignee: Tian Hong Wang


In TestRBWBlockInvalidation, the original code is:
while (!isCorruptReported) {
        if (countReplicas(namesystem, blk).corruptReplicas() > 0) {
          isCorruptReported = true;
        }
        Thread.sleep(100);
}
assertEquals("There should be 1 replica in the corruptReplicasMap", 1,
          countReplicas(namesystem, blk).corruptReplicas());

Once the program detects there exists one corruptReplica, it will break the while loop. After that, it call countReplicas() again in assertEquals(). But sometimes I met the following error:
java.lang.AssertionError: There should be 1 replica in the corruptReplicasMap expected:<1> but was:<0>

It's obviously that second call countReplicas() in assertEquals(), the corruptReplicas value has been changed since program go to sleep and BlockManger recovered the block. 

So what I do is:
1) once detecting there exists one corruptReplica, break the loop and don't call sleep, the same as liveReplicas
2) don't double check the countReplicas & liveReplicas
3) sometime I meet the problem of testcase timeout, so I speed up the block report interval


--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira