You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@streams.apache.org by steveblackmon <gi...@git.apache.org> on 2014/10/08 01:35:57 UTC

[GitHub] incubator-streams pull request: added scrollTimeout to Elasticsear...

GitHub user steveblackmon opened a pull request:

    https://github.com/apache/incubator-streams/pull/97

    added scrollTimeout to ElasticsearchReaderConfiguration

    removed some legacy properties
    simplified default behaviors

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/apache/incubator-streams STREAMS-188

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-streams/pull/97.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #97
    
----
commit be084f078cd11bcc0b6d6ed80fb142398b1eda41
Author: Steve Blackmon <sb...@w2odigital.com>
Date:   2014-10-07T23:29:15Z

    added scrollTimeout to ElasticsearchReaderConfiguration
    removed some legacy properties
    simplified default behaviors

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-streams pull request: added scrollTimeout to Elasticsear...

Posted by robdouglas <gi...@git.apache.org>.
Github user robdouglas commented on the pull request:

    https://github.com/apache/incubator-streams/pull/97#issuecomment-58424635
  
    :+1: 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-streams pull request: added scrollTimeout to Elasticsear...

Posted by robdouglas <gi...@git.apache.org>.
Github user robdouglas commented on a diff in the pull request:

    https://github.com/apache/incubator-streams/pull/97#discussion_r18601265
  
    --- Diff: streams-contrib/streams-persist-elasticsearch/src/main/java/org/apache/streams/elasticsearch/ElasticsearchQuery.java ---
    @@ -128,8 +122,8 @@ public void execute(Object o) {
                         .setExplain(true)
                         .addField("*")
                         .setFetchSource(true)
    -                    .setSize(Objects.firstNonNull(batchSize, DEFAULT_BATCH_SIZE).intValue())
    --- End diff --
    
    What happens if batchSize is null?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-streams pull request: added scrollTimeout to Elasticsear...

Posted by steveblackmon <gi...@git.apache.org>.
Github user steveblackmon commented on a diff in the pull request:

    https://github.com/apache/incubator-streams/pull/97#discussion_r18610515
  
    --- Diff: streams-contrib/streams-persist-elasticsearch/src/main/java/org/apache/streams/elasticsearch/ElasticsearchQuery.java ---
    @@ -128,8 +122,8 @@ public void execute(Object o) {
                         .setExplain(true)
                         .addField("*")
                         .setFetchSource(true)
    -                    .setSize(Objects.firstNonNull(batchSize, DEFAULT_BATCH_SIZE).intValue())
    --- End diff --
    
    It can't be.  It has a default value in the generated configuration object.
    
    Steve Blackmon
    
    > On Oct 8, 2014, at 1:14 PM, Robert Douglas <no...@github.com> wrote:
    > 
    > In streams-contrib/streams-persist-elasticsearch/src/main/java/org/apache/streams/elasticsearch/ElasticsearchQuery.java:
    > 
    > > @@ -128,8 +122,8 @@ public void execute(Object o) {
    > >                      .setExplain(true)
    > >                      .addField("*")
    > >                      .setFetchSource(true)
    > > -                    .setSize(Objects.firstNonNull(batchSize, DEFAULT_BATCH_SIZE).intValue())
    > What happens if batchSize is null?
    > 
    > —
    > Reply to this email directly or view it on GitHub.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-streams pull request: added scrollTimeout to Elasticsear...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/incubator-streams/pull/97


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---