You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@bookkeeper.apache.org by Ivan Kelly <iv...@apache.org> on 2012/03/29 17:05:21 UTC
Review Request: BOOKKEEPER-196 Define interface between bookie and ledger
storage
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4556/
-----------------------------------------------------------
Review request for bookkeeper.
Summary
-------
EntryLogger and LedgerCache are both part of a very interdependent storage mechanism where entries are interleaved in a single log(EntryLogger) and index files are maintained (LedgerCache). I'd like to experiment with some other schemes (Im not convinced the interleaving is required for high performance). ZOOKEEPER-507 brought in these changes, but it also brought in a lot of other stuff, and I think its the other stuff (specifically taking the writing to separate files out of the critical path) which gave us the performance boost. To do this cleanly, we need a well defined storage interface for this. This JIRA is to provide this. Future work can move the interleaved implementation into another package as org.apache.bookkeeper.bookie is getting a little crowded now.
Diffs
-----
bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/Bookie.java ee38862
bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/EntryLogger.java d4f2111
bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/GarbageCollectorThread.java 2eed192
bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/HandleFactoryImpl.java c240682
bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/LedgerDescriptor.java 1e464df
bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/LedgerDescriptorImpl.java f79b432
bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/LedgerDescriptorReadOnlyImpl.java bda0b59
Diff: https://reviews.apache.org/r/4556/diff
Testing
-------
Thanks,
Ivan
Re: Review Request: BOOKKEEPER-196 Define interface between bookie and
ledger storage
Posted by Ivan Kelly <iv...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4556/
-----------------------------------------------------------
(Updated 2012-03-29 15:16:28.434700)
Review request for bookkeeper.
Summary
-------
EntryLogger and LedgerCache are both part of a very interdependent storage mechanism where entries are interleaved in a single log(EntryLogger) and index files are maintained (LedgerCache). I'd like to experiment with some other schemes (Im not convinced the interleaving is required for high performance). ZOOKEEPER-507 brought in these changes, but it also brought in a lot of other stuff, and I think its the other stuff (specifically taking the writing to separate files out of the critical path) which gave us the performance boost. To do this cleanly, we need a well defined storage interface for this. This JIRA is to provide this. Future work can move the interleaved implementation into another package as org.apache.bookkeeper.bookie is getting a little crowded now.
Diffs (updated)
-----
bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/Bookie.java ee38862
bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/EntryLogger.java d4f2111
bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/GarbageCollectorThread.java 2eed192
bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/HandleFactoryImpl.java c240682
bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/InterleavedLedgerStorage.java PRE-CREATION
bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/LedgerDescriptor.java 1e464df
bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/LedgerDescriptorImpl.java f79b432
bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/LedgerDescriptorReadOnlyImpl.java bda0b59
bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/LedgerStorage.java PRE-CREATION
Diff: https://reviews.apache.org/r/4556/diff
Testing
-------
Thanks,
Ivan