You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2020/09/24 23:23:57 UTC
[GitHub] [incubator-tvm] trevor-m opened a new pull request #6553: [RELAY][ConvertLayout] Make missing desired layout non-fatal
trevor-m opened a new pull request #6553:
URL: https://github.com/apache/incubator-tvm/pull/6553
When ConvertLayout encounters an operator which is supported by ConvertLayout but a desired_layout is not provided by the user, it will create a fatal error. With this PR, it will instead just give a warning and leave that operator how it was.
Currently, anytime a new operator is added to ConvertLayout, it will break ConvertLayout for anyone using it in their code. For example, a BYOC target may want all Conv2D ops to be converted to NCHW but doesn't care about the layout of other ops. They shouldn't have to specify a desired layout for every single op which is supported by ConvertLayout, only the ones which they care about.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-tvm] anijain2305 merged pull request #6553: [RELAY][ConvertLayout] Make missing desired layout non-fatal
Posted by GitBox <gi...@apache.org>.
anijain2305 merged pull request #6553:
URL: https://github.com/apache/incubator-tvm/pull/6553
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-tvm] anijain2305 commented on pull request #6553: [RELAY][ConvertLayout] Make missing desired layout non-fatal
Posted by GitBox <gi...@apache.org>.
anijain2305 commented on pull request #6553:
URL: https://github.com/apache/incubator-tvm/pull/6553#issuecomment-699001093
Thanks @trevor-m @comaniac this is merged!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-tvm] trevor-m commented on pull request #6553: [RELAY][ConvertLayout] Make missing desired layout non-fatal
Posted by GitBox <gi...@apache.org>.
trevor-m commented on pull request #6553:
URL: https://github.com/apache/incubator-tvm/pull/6553#issuecomment-698637390
@anijain2305 Could you please review? Thanks!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-tvm] trevor-m commented on pull request #6553: [RELAY][ConvertLayout] Make missing desired layout non-fatal
Posted by GitBox <gi...@apache.org>.
trevor-m commented on pull request #6553:
URL: https://github.com/apache/incubator-tvm/pull/6553#issuecomment-698637390
@anijain2305 Could you please review? Thanks!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org