You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by sarutak <gi...@git.apache.org> on 2014/11/05 12:12:26 UTC
[GitHub] incubator-flink pull request: [FLINK-1213] Add .gitattributes to n...
GitHub user sarutak opened a pull request:
https://github.com/apache/incubator-flink/pull/181
[FLINK-1213] Add .gitattributes to normalize EOL character.
Flink has Windows batch files and Linux user, Mac OSX user and Windows user can edit those files. So I think we should normalize EOL character of batch files using .gitattributes.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/sarutak/incubator-flink eol-modification
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-flink/pull/181.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #181
----
commit b8841e5a33a501f4666cd4f2be517e1b9170e718
Author: Kousuke Saruta <sa...@oss.nttdata.co.jp>
Date: 2014-11-05T11:00:57Z
Added .gitattributes to normalize EOL
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-flink pull request: [FLINK-1213] Add .gitattributes to n...
Posted by sarutak <gi...@git.apache.org>.
Github user sarutak closed the pull request at:
https://github.com/apache/incubator-flink/pull/181
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-flink pull request: [FLINK-1213] Add .gitattributes to n...
Posted by StephanEwen <gi...@git.apache.org>.
Github user StephanEwen commented on the pull request:
https://github.com/apache/incubator-flink/pull/181#issuecomment-62124398
Will merge the path.
Thanks you contributing this patch!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-flink pull request: [FLINK-1213] Add .gitattributes to n...
Posted by StephanEwen <gi...@git.apache.org>.
Github user StephanEwen commented on the pull request:
https://github.com/apache/incubator-flink/pull/181#issuecomment-62036589
Looks like a good fix.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-flink pull request: [FLINK-1213] Add .gitattributes to n...
Posted by rmetzger <gi...@git.apache.org>.
Github user rmetzger commented on the pull request:
https://github.com/apache/incubator-flink/pull/181#issuecomment-62364216
Hey @sarutak, can you close the issue for us? (We don't have permissions to do that)
It seems that GitHub did not properly detect that the pull request has been merged.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-flink pull request: [FLINK-1213] Add .gitattributes to n...
Posted by sarutak <gi...@git.apache.org>.
Github user sarutak commented on the pull request:
https://github.com/apache/incubator-flink/pull/181#issuecomment-62382496
@rmetzger Thanks for notification. I close this PR.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---