You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@geode.apache.org by "sboorlagadda (GitHub)" <gi...@apache.org> on 2018/10/26 17:50:04 UTC

[GitHub] [geode-native] sboorlagadda opened pull request #385: GEODE-5942: prefix variables in PersistenceManager

  PAGE_SIZE causes conflicts with system library header files.
  So adding a PM prefix to all variables in PersistenceManager.

Signed-off-by: Matthew Reddington <mr...@gmail.com>

[ Full content available at: https://github.com/apache/geode-native/pull/385 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode-native] pivotal-jbarrett commented on issue #385: GEODE-5942: prefix variables in PersistenceManager

Posted by "pivotal-jbarrett (GitHub)" <gi...@apache.org>.

Well this sucks. Even after making this change this `PAGE_SIZE` name still trips you up from time to time on MacOS. I suggest we change it but but suffixing with `_KEY` since these are used as keys in a property object.

[ Full content available at: https://github.com/apache/geode-native/pull/385 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode-native] pdxcodemonkey closed pull request #385: GEODE-5942: prefix variables in PersistenceManager

Posted by "pdxcodemonkey (GitHub)" <gi...@apache.org>.

[ pull request closed by pdxcodemonkey ]

[ Full content available at: https://github.com/apache/geode-native/pull/385 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode-native] pivotal-jbarrett commented on issue #385: GEODE-5942: prefix variables in PersistenceManager

Posted by "pivotal-jbarrett (GitHub)" <gi...@apache.org>.

See https://github.com/apache/geode-native/pull/387/commits/2fb3838dfc5f4249d0479586af1ed75a14606f64


[ Full content available at: https://github.com/apache/geode-native/pull/385 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode-native] pdxcodemonkey commented on issue #385: GEODE-5942: prefix variables in PersistenceManager

Posted by "pdxcodemonkey (GitHub)" <gi...@apache.org>.

This is superseded by PR #393, closing.

[ Full content available at: https://github.com/apache/geode-native/pull/385 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode-native] pivotal-jbarrett commented on issue #385: GEODE-5942: prefix variables in PersistenceManager

Posted by "pivotal-jbarrett (GitHub)" <gi...@apache.org>.

Well this sucks. Even after making my change to headers the `PAGE_SIZE` name still trips you up from time to time on MacOS. I suggest we change it but but suffixing with `_KEY` since these are used as keys in a property object.

[ Full content available at: https://github.com/apache/geode-native/pull/385 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org