You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by Thiruvel Thirumoolan <th...@yahoo-inc.com> on 2015/02/18 03:56:28 UTC
Review Request 31146: HIVE-9508: MetaStore client socket connection
should have a lifetime
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31146/
-----------------------------------------------------------
Review request for hive.
Repository: hive-git
Description
-------
HIVE-9508: MetaStore client socket connection should have a lifetime
Diffs
-----
common/src/java/org/apache/hadoop/hive/conf/HiveConf.java e64e8fc11cbfe3e538440cd9ca344397baf1dc17
itests/hive-unit/src/test/java/org/apache/hadoop/hive/metastore/TestHiveMetaStore.java 130fd67175091daf00268495093853fba63e3884
metastore/src/java/org/apache/hadoop/hive/metastore/RetryingMetaStoreClient.java b4f02fc1c519096b71a7e0c10567049a9ccdf13e
Diff: https://reviews.apache.org/r/31146/diff/
Testing
-------
1. Added a unit test case.
2. Tested on a live deployment with the fix. The client reconnected after 5 minutes.
Thanks,
Thiruvel Thirumoolan
Re: Review Request 31146: HIVE-9508: MetaStore client socket
connection should have a lifetime
Posted by Thiruvel Thirumoolan <th...@yahoo-inc.com>.
> On April 30, 2015, 9:29 p.m., Vaibhav Gumashta wrote:
> > common/src/java/org/apache/hadoop/hive/conf/HiveConf.java, line 403
> > <https://reviews.apache.org/r/31146/diff/3/?file=946416#file946416line403>
> >
> > Can you add a small comment here to indicate that 0s means this config is disabled? You might want to add the new config to HiveConf.metaVars as well.
I have rephrased the whole description. Please let me know if this looks ok.
Good catch, I forgot about the metaVars.
- Thiruvel
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31146/#review82203
-----------------------------------------------------------
On April 30, 2015, 11:33 p.m., Thiruvel Thirumoolan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31146/
> -----------------------------------------------------------
>
> (Updated April 30, 2015, 11:33 p.m.)
>
>
> Review request for hive.
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> HIVE-9508: MetaStore client socket connection should have a lifetime
>
>
> Diffs
> -----
>
> common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 72e4ff2
> itests/hive-unit/src/test/java/org/apache/hadoop/hive/metastore/TestHiveMetaStore.java 130fd67
> metastore/src/java/org/apache/hadoop/hive/metastore/RetryingMetaStoreClient.java 5ce58ee
>
> Diff: https://reviews.apache.org/r/31146/diff/
>
>
> Testing
> -------
>
> 1. Added a unit test case.
> 2. Tested on a live deployment with the fix. The client reconnected after 5 minutes.
>
>
> Thanks,
>
> Thiruvel Thirumoolan
>
>
Re: Review Request 31146: HIVE-9508: MetaStore client socket
connection should have a lifetime
Posted by Vaibhav Gumashta <vg...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31146/#review82203
-----------------------------------------------------------
common/src/java/org/apache/hadoop/hive/conf/HiveConf.java
<https://reviews.apache.org/r/31146/#comment132900>
Can you add a small comment here to indicate that 0s means this config is disabled? You might want to add the new config to HiveConf.metaVars as well.
- Vaibhav Gumashta
On April 30, 2015, 7:28 p.m., Thiruvel Thirumoolan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31146/
> -----------------------------------------------------------
>
> (Updated April 30, 2015, 7:28 p.m.)
>
>
> Review request for hive.
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> HIVE-9508: MetaStore client socket connection should have a lifetime
>
>
> Diffs
> -----
>
> common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 72e4ff2
> itests/hive-unit/src/test/java/org/apache/hadoop/hive/metastore/TestHiveMetaStore.java 130fd67
> metastore/src/java/org/apache/hadoop/hive/metastore/RetryingMetaStoreClient.java 5ce58ee
>
> Diff: https://reviews.apache.org/r/31146/diff/
>
>
> Testing
> -------
>
> 1. Added a unit test case.
> 2. Tested on a live deployment with the fix. The client reconnected after 5 minutes.
>
>
> Thanks,
>
> Thiruvel Thirumoolan
>
>
Re: Review Request 31146: HIVE-9508: MetaStore client socket
connection should have a lifetime
Posted by Vaibhav Gumashta <vg...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31146/#review82375
-----------------------------------------------------------
Ship it!
Ship It!
- Vaibhav Gumashta
On April 30, 2015, 11:33 p.m., Thiruvel Thirumoolan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31146/
> -----------------------------------------------------------
>
> (Updated April 30, 2015, 11:33 p.m.)
>
>
> Review request for hive.
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> HIVE-9508: MetaStore client socket connection should have a lifetime
>
>
> Diffs
> -----
>
> common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 72e4ff2
> itests/hive-unit/src/test/java/org/apache/hadoop/hive/metastore/TestHiveMetaStore.java 130fd67
> metastore/src/java/org/apache/hadoop/hive/metastore/RetryingMetaStoreClient.java 5ce58ee
>
> Diff: https://reviews.apache.org/r/31146/diff/
>
>
> Testing
> -------
>
> 1. Added a unit test case.
> 2. Tested on a live deployment with the fix. The client reconnected after 5 minutes.
>
>
> Thanks,
>
> Thiruvel Thirumoolan
>
>
Re: Review Request 31146: HIVE-9508: MetaStore client socket
connection should have a lifetime
Posted by Thiruvel Thirumoolan <th...@yahoo-inc.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31146/
-----------------------------------------------------------
(Updated April 30, 2015, 11:33 p.m.)
Review request for hive.
Repository: hive-git
Description
-------
HIVE-9508: MetaStore client socket connection should have a lifetime
Diffs (updated)
-----
common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 72e4ff2
itests/hive-unit/src/test/java/org/apache/hadoop/hive/metastore/TestHiveMetaStore.java 130fd67
metastore/src/java/org/apache/hadoop/hive/metastore/RetryingMetaStoreClient.java 5ce58ee
Diff: https://reviews.apache.org/r/31146/diff/
Testing
-------
1. Added a unit test case.
2. Tested on a live deployment with the fix. The client reconnected after 5 minutes.
Thanks,
Thiruvel Thirumoolan
Re: Review Request 31146: HIVE-9508: MetaStore client socket
connection should have a lifetime
Posted by Thiruvel Thirumoolan <th...@yahoo-inc.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31146/
-----------------------------------------------------------
(Updated April 30, 2015, 7:28 p.m.)
Review request for hive.
Repository: hive-git
Description
-------
HIVE-9508: MetaStore client socket connection should have a lifetime
Diffs (updated)
-----
common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 72e4ff2
itests/hive-unit/src/test/java/org/apache/hadoop/hive/metastore/TestHiveMetaStore.java 130fd67
metastore/src/java/org/apache/hadoop/hive/metastore/RetryingMetaStoreClient.java 5ce58ee
Diff: https://reviews.apache.org/r/31146/diff/
Testing
-------
1. Added a unit test case.
2. Tested on a live deployment with the fix. The client reconnected after 5 minutes.
Thanks,
Thiruvel Thirumoolan
Re: Review Request 31146: HIVE-9508: MetaStore client socket
connection should have a lifetime
Posted by Thiruvel Thirumoolan <th...@yahoo-inc.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31146/
-----------------------------------------------------------
(Updated April 29, 2015, 8:34 p.m.)
Review request for hive.
Repository: hive-git
Description
-------
HIVE-9508: MetaStore client socket connection should have a lifetime
Diffs (updated)
-----
common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 72e4ff2
itests/hive-unit/src/test/java/org/apache/hadoop/hive/metastore/TestHiveMetaStore.java 130fd67
metastore/src/java/org/apache/hadoop/hive/metastore/RetryingMetaStoreClient.java 5ce58ee
Diff: https://reviews.apache.org/r/31146/diff/
Testing
-------
1. Added a unit test case.
2. Tested on a live deployment with the fix. The client reconnected after 5 minutes.
Thanks,
Thiruvel Thirumoolan
Re: Review Request 31146: HIVE-9508: MetaStore client socket
connection should have a lifetime
Posted by Vaibhav Gumashta <vg...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31146/#review81728
-----------------------------------------------------------
Ship it!
Ship It!
- Vaibhav Gumashta
On Feb. 18, 2015, 2:56 a.m., Thiruvel Thirumoolan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31146/
> -----------------------------------------------------------
>
> (Updated Feb. 18, 2015, 2:56 a.m.)
>
>
> Review request for hive.
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> HIVE-9508: MetaStore client socket connection should have a lifetime
>
>
> Diffs
> -----
>
> common/src/java/org/apache/hadoop/hive/conf/HiveConf.java e64e8fc11cbfe3e538440cd9ca344397baf1dc17
> itests/hive-unit/src/test/java/org/apache/hadoop/hive/metastore/TestHiveMetaStore.java 130fd67175091daf00268495093853fba63e3884
> metastore/src/java/org/apache/hadoop/hive/metastore/RetryingMetaStoreClient.java b4f02fc1c519096b71a7e0c10567049a9ccdf13e
>
> Diff: https://reviews.apache.org/r/31146/diff/
>
>
> Testing
> -------
>
> 1. Added a unit test case.
> 2. Tested on a live deployment with the fix. The client reconnected after 5 minutes.
>
>
> Thanks,
>
> Thiruvel Thirumoolan
>
>