You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by SrikanteswaraRao Talluri <sr...@citrix.com> on 2013/05/07 17:58:21 UTC
Review Request: fix userdata integration test
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10976/
-----------------------------------------------------------
Review request for cloudstack and Prasanna Santhanam.
Description
-------
Clean up the VM created in each test in tearDown method otherwise test is failing because it verifies the first VM in the list VM.
This addresses bug CLOUDSTACK-2362.
Diffs
-----
test/integration/smoke/test_deploy_vm_with_userdata.py fd9e320
Diff: https://reviews.apache.org/r/10976/diff/
Testing
-------
Test userdata as GET, size > 2k ... ok
Test userdata as POST, size > 2k ... ok
----------------------------------------------------------------------
XML: /tmp/r.xml
----------------------------------------------------------------------
Ran 2 tests in 401.378s
OK
Thanks,
SrikanteswaraRao Talluri
Re: Review Request: fix userdata integration test
Posted by Prasanna Santhanam <ts...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10976/#review20304
-----------------------------------------------------------
Ship it!
commit 731cc439a363fd3b17b1ed5eeca51f92f9e993cc
Author: Talluri <Sr...@citrix.com>
Date: Wed May 8 14:12:46 2013 +0530
CLOUDSTACK-2362: correct list append method
fix userdata integration test
- Prasanna Santhanam
On May 7, 2013, 4:06 p.m., SrikanteswaraRao Talluri wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10976/
> -----------------------------------------------------------
>
> (Updated May 7, 2013, 4:06 p.m.)
>
>
> Review request for cloudstack and Prasanna Santhanam.
>
>
> Description
> -------
>
> Clean up the VM created in each test in tearDown method otherwise test is failing because it verifies the first VM in the list VM.
>
>
> This addresses bug CLOUDSTACK-2362.
>
>
> Diffs
> -----
>
> test/integration/smoke/test_deploy_vm_with_userdata.py fd9e320
>
> Diff: https://reviews.apache.org/r/10976/diff/
>
>
> Testing
> -------
>
> Test userdata as GET, size > 2k ... ok
> Test userdata as POST, size > 2k ... ok
>
> ----------------------------------------------------------------------
> XML: /tmp/r.xml
> ----------------------------------------------------------------------
> Ran 2 tests in 401.378s
>
> OK
>
>
> Thanks,
>
> SrikanteswaraRao Talluri
>
>
Re: Review Request: fix userdata integration test
Posted by SrikanteswaraRao Talluri <sr...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10976/
-----------------------------------------------------------
(Updated May 7, 2013, 4:06 p.m.)
Review request for cloudstack and Prasanna Santhanam.
Changes
-------
updated diff
Description
-------
Clean up the VM created in each test in tearDown method otherwise test is failing because it verifies the first VM in the list VM.
This addresses bug CLOUDSTACK-2362.
Diffs (updated)
-----
test/integration/smoke/test_deploy_vm_with_userdata.py fd9e320
Diff: https://reviews.apache.org/r/10976/diff/
Testing
-------
Test userdata as GET, size > 2k ... ok
Test userdata as POST, size > 2k ... ok
----------------------------------------------------------------------
XML: /tmp/r.xml
----------------------------------------------------------------------
Ran 2 tests in 401.378s
OK
Thanks,
SrikanteswaraRao Talluri