You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2022/06/30 22:11:23 UTC
[GitHub] [kafka] niket-goel opened a new pull request, #12371: KMETA-213: Fix NPE caused by missing null check in SnapshottableHashTable::mergeFrom()
niket-goel opened a new pull request, #12371:
URL: https://github.com/apache/kafka/pull/12371
Also adds a simple test case that fails without the check
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] iblislin commented on pull request #12371: KAFKA-14035: Fix NPE caused by missing null check in SnapshottableHashTable::mergeFrom()
Posted by GitBox <gi...@apache.org>.
iblislin commented on PR #12371:
URL: https://github.com/apache/kafka/pull/12371#issuecomment-1370578419
Hi,
I still ran into the issue of NPE on a 3.3.1 cluster with 3 nodes.
The actual line throwing the NPE is here: https://github.com/apache/kafka/blob/3.3.1/metadata/src/main/java/org/apache/kafka/timeline/SnapshottableHashTable.java#L125
But I cannot speak in Java, no idea about the root cause.
The traceback:
```
kafka-k3-1 | [2023-01-04 06:23:20,276] ERROR Encountered fatal fault: exception while renouncing leadership (org.apache.kafka.server.fault.ProcessExitingFaultHandler)
kafka-k3-1 | java.lang.NullPointerException
kafka-k3-1 | at org.apache.kafka.timeline.SnapshottableHashTable$HashTier.mergeFrom(SnapshottableHashTable.java:125)
kafka-k3-1 | at org.apache.kafka.timeline.Snapshot.mergeFrom(Snapshot.java:68)
kafka-k3-1 | at org.apache.kafka.timeline.SnapshotRegistry.deleteSnapshot(SnapshotRegistry.java:236)
kafka-k3-1 | at org.apache.kafka.timeline.SnapshotRegistry$SnapshotIterator.remove(SnapshotRegistry.java:67)
kafka-k3-1 | at org.apache.kafka.timeline.SnapshotRegistry.revertToSnapshot(SnapshotRegistry.java:214)
kafka-k3-1 | at org.apache.kafka.controller.QuorumController.renounce(QuorumController.java:1232)
kafka-k3-1 | at org.apache.kafka.controller.QuorumController.access$3300(QuorumController.java:150)
kafka-k3-1 | at org.apache.kafka.controller.QuorumController$QuorumMetaLogListener.lambda$handleLeaderChange$3(QuorumController.java:1076)
kafka-k3-1 | at org.apache.kafka.controller.QuorumController$QuorumMetaLogListener.lambda$appendRaftEvent$4(QuorumController.java:1101)
kafka-k3-1 | at org.apache.kafka.controller.QuorumController$ControlEvent.run(QuorumController.java:496)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] iblislin commented on pull request #12371: KAFKA-14035: Fix NPE caused by missing null check in SnapshottableHashTable::mergeFrom()
Posted by GitBox <gi...@apache.org>.
iblislin commented on PR #12371:
URL: https://github.com/apache/kafka/pull/12371#issuecomment-1370579167
There are related discussions on StackOverflow: https://stackoverflow.com/questions/74679400.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] hachikuji merged pull request #12371: KAFKA-14035: Fix NPE caused by missing null check in SnapshottableHashTable::mergeFrom()
Posted by GitBox <gi...@apache.org>.
hachikuji merged PR #12371:
URL: https://github.com/apache/kafka/pull/12371
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] showuon commented on pull request #12371: KAFKA-14035: Fix NPE caused by missing null check in SnapshottableHashTable::mergeFrom()
Posted by "showuon (via GitHub)" <gi...@apache.org>.
showuon commented on PR #12371:
URL: https://github.com/apache/kafka/pull/12371#issuecomment-1547118612
@iblislin @hoangphuocbk , this issue will be fixed in v3.4.1 and v3.5.0 via this patch: https://github.com/apache/kafka/pull/13653 . Thanks for reporting.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] iblislin commented on pull request #12371: KAFKA-14035: Fix NPE caused by missing null check in SnapshottableHashTable::mergeFrom()
Posted by "iblislin (via GitHub)" <gi...@apache.org>.
iblislin commented on PR #12371:
URL: https://github.com/apache/kafka/pull/12371#issuecomment-1547081430
@hoangphuocbk yeah, that patch works fine for me. I have a kraft cluster with that patch eanbled up for 45 days already.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] hoangphuocbk commented on pull request #12371: KAFKA-14035: Fix NPE caused by missing null check in SnapshottableHashTable::mergeFrom()
Posted by "hoangphuocbk (via GitHub)" <gi...@apache.org>.
hoangphuocbk commented on PR #12371:
URL: https://github.com/apache/kafka/pull/12371#issuecomment-1544342962
@iblislin, I had same problem. Did your solution work?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org