You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by "Ben Craig (JIRA)" <ji...@apache.org> on 2015/07/15 16:59:05 UTC
[jira] [Reopened] (THRIFT-2858) Enable header field case
insensitive match in THttpServer
[ https://issues.apache.org/jira/browse/THRIFT-2858?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ben Craig reopened THRIFT-2858:
-------------------------------
This breaks the windows build. Windows doesn't have a strncasecmp or strcasestr.
Pull request will be here shortly (though it will only really be exercised by travis CI)
> Enable header field case insensitive match in THttpServer
> ---------------------------------------------------------
>
> Key: THRIFT-2858
> URL: https://issues.apache.org/jira/browse/THRIFT-2858
> Project: Thrift
> Issue Type: Bug
> Components: C++ - Library
> Affects Versions: 0.9.1, 0.9.2
> Environment: ubuntu 14.04 LTS
> gcc 4.8
> Reporter: YI-HUNG JEN
> Assignee: Roger Meier
> Labels: patch
> Fix For: 0.9.3
>
> Attachments: thrift-2858-enable-THttpServer_cpp-header-case-insensitive-match.patch
>
> Original Estimate: 1h
> Remaining Estimate: 1h
>
> Communications between THttpServer in cpp lib and nodejs http client caused unexpected ECONNRESET. This was caused by nodejs client setting "Content-length" instead of "Content-Length" in the header field, causing THttpServer to terminate the request prematurely.
> Per HTTP specification, header field name is case insensitive, therefore this patch used case insensitive match to identify "Content-Length" field.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)