You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2020/04/30 19:14:57 UTC
[GitHub] [incubator-tvm] tqchen opened a new issue #5490: [REFACTOR] std::string -> String Migration in IR nodes
tqchen opened a new issue #5490:
URL: https://github.com/apache/incubator-tvm/issues/5490
This is an issue to track the progress of std::string -> String migration in IR Nodes.
- [ ] Merge initial example https://github.com/apache/incubator-tvm/pull/5438
- [ ] Convert relay nodes
- [ ] Convert base types
- [ ] Convert tir nodes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-tvm] tqchen commented on issue #5490: [REFACTOR] std::string -> String Migration in IR nodes
Posted by GitBox <gi...@apache.org>.
tqchen commented on issue #5490:
URL: https://github.com/apache/incubator-tvm/issues/5490#issuecomment-622050597
cc @icemelon9 @jroesch @zhiics please chime in if you would like to take a stab
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-tvm] tqchen closed issue #5490: [REFACTOR] std::string -> String Migration in IR nodes
Posted by GitBox <gi...@apache.org>.
tqchen closed issue #5490:
URL: https://github.com/apache/incubator-tvm/issues/5490
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-tvm] tqchen commented on issue #5490: [REFACTOR] std::string -> String Migration in IR nodes
Posted by GitBox <gi...@apache.org>.
tqchen commented on issue #5490:
URL: https://github.com/apache/incubator-tvm/issues/5490#issuecomment-624408382
NOTE, as in the intiial example, we will need to update the converter(via _update_from_std_str) to keep backward compatibility of the nodes
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-tvm] tqchen edited a comment on issue #5490: [REFACTOR] std::string -> String Migration in IR nodes
Posted by GitBox <gi...@apache.org>.
tqchen edited a comment on issue #5490:
URL: https://github.com/apache/incubator-tvm/issues/5490#issuecomment-624408382
## IMPORTANT NOTE
as shown in the intiial example, we will need to update the converter(via `_update_from_std_str`) to keep backward compatibility of the nodes.
To test the correctness, use `tvm.ir.save_json` to save a node (that is involved in the change) before the migration, and then use `tvm.ir.load_json` to load it back after change
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-tvm] ANSHUMAN87 commented on issue #5490: [REFACTOR] std::string -> String Migration in IR nodes
Posted by GitBox <gi...@apache.org>.
ANSHUMAN87 commented on issue #5490:
URL: https://github.com/apache/incubator-tvm/issues/5490#issuecomment-624495276
I like to contribute for this movement. May be we can share the workload, if @zhiics already working on it. Please let me know.Thanks!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-tvm] zhiics commented on issue #5490: [REFACTOR] std::string -> String Migration in IR nodes
Posted by GitBox <gi...@apache.org>.
zhiics commented on issue #5490:
URL: https://github.com/apache/incubator-tvm/issues/5490#issuecomment-624723623
@ANSHUMAN87 Welcome to contribute. I've busy with other things recently. Thanks.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org