[GitHub] [trafficserver] maskit commented on pull request #8015: Update documentation of the url log fields

[GitBox <gi...@apache.org>]

maskit commented on pull request #8015:
URL: https://github.com/apache/trafficserver/pull/8015#issuecomment-876966170


   I don't think the changes are correct because "cq" in log field names mean "Client reQuest". In fact, the data source of `cqu` is `LogAccess::m_client_request` but not `LogAccess::m_proxy_request`.
   
   Are we sure `m_client_request` and `m_proxy_request` always have the same URL regardless of transaction state? In other words, can we really change the data source to `m_proxy_request` ?
   
   If the answer is yes, the new descriptions probably match actual outputs. However, using "cq" for data from Proxy Request doesn't seem correct. I'd deprecate confusing `cqu` and rename it to `pqu`, and also change the data source to `m_proxy_request`.
   
   If the answer is no, the doc should not say the source is Proxy Request (nor URL in a request form proxy to origin).
   
   Log field names for content length is very clear. We should have followed this manner.
   ```
   cqcl | Client Request | Client request content length, in bytes.
   pqcl | Proxy Request | Content body length of the Traffic Server proxy request to the origin server.
   pscl | Proxy Response | Content body length of the Traffic Server proxy response.
   sscl | Origin Response | Content body length of the origin server response to Traffic Server.
   ```
   
   
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org