Re: [PATCH] Set permissions on new fsfs shard dirs

[Peter Samuelson <pe...@p12n.org>]

[Peter Samuelson]
> When creating a new fsfs shard directory (revs/N, revprops/N), set its
> permissions correctly.
> 
> * subversion/libsvn_fs_fs/fs_fs.c
>   (svn_fs_fs__hotcopy): Set permissions of a shard dir in revs/ and
>     revprops/ after creating it.
>   (commit_body): Ditto.

r32355, and proposed for 1.5.2.  I didn't create a test case, I don't
know if that's important for something as small as this.
-- 
Peter Samuelson | org-tld!p12n!peter | http://p12n.org/

Re: [PATCH] Set permissions on new fsfs shard dirs

[Karl Fogel <kf...@red-bean.com>]

Peter Samuelson <pe...@p12n.org> writes:
>> When creating a new fsfs shard directory (revs/N, revprops/N), set its
>> permissions correctly.
>> 
>> * subversion/libsvn_fs_fs/fs_fs.c
>>   (svn_fs_fs__hotcopy): Set permissions of a shard dir in revs/ and
>>     revprops/ after creating it.
>>   (commit_body): Ditto.
>
> r32355, and proposed for 1.5.2.  I didn't create a test case, I don't
> know if that's important for something as small as this.

In an ideal world, we'd have test cases for every change.

In real life, yeah, I agree with your priorities -- this is not the sort
of change worth spending further hours of your time writing a test.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org