You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hive.apache.org by ha...@apache.org on 2014/05/19 20:10:27 UTC

svn commit: r1595987 - in /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql: exec/vector/VectorColumnAssignFactory.java io/parquet/VectorizedParquetInputFormat.java

Author: hashutosh
Date: Mon May 19 18:10:27 2014
New Revision: 1595987

URL: http://svn.apache.org/r1595987
Log:
HIVE-7082 : Vectorized parquet reader should create assigners only for the columns it assigns, not for scratch columns (Remus Rusanu via Ashutosh Chauhan)

Modified:
    hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/vector/VectorColumnAssignFactory.java
    hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/io/parquet/VectorizedParquetInputFormat.java

Modified: hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/vector/VectorColumnAssignFactory.java
URL: http://svn.apache.org/viewvc/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/vector/VectorColumnAssignFactory.java?rev=1595987&r1=1595986&r2=1595987&view=diff
==============================================================================
--- hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/vector/VectorColumnAssignFactory.java (original)
+++ hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/vector/VectorColumnAssignFactory.java Mon May 19 18:10:27 2014
@@ -473,7 +473,7 @@ public class VectorColumnAssignFactory {
   public static VectorColumnAssign[] buildAssigners(VectorizedRowBatch outputBatch,
       Writable[] writables) throws HiveException {
     VectorColumnAssign[] vcas = new VectorColumnAssign[outputBatch.numCols];
-    for (int i = 0; i < outputBatch.numCols; ++i) {
+    for (int i = 0; i < writables.length; ++i) {
       if (writables[i] == null) {
         assert(outputBatch.cols[i] == null);
         vcas[i] = buildObjectAssign(outputBatch, i, PrimitiveCategory.VOID);

Modified: hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/io/parquet/VectorizedParquetInputFormat.java
URL: http://svn.apache.org/viewvc/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/io/parquet/VectorizedParquetInputFormat.java?rev=1595987&r1=1595986&r2=1595987&view=diff
==============================================================================
--- hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/io/parquet/VectorizedParquetInputFormat.java (original)
+++ hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/io/parquet/VectorizedParquetInputFormat.java Mon May 19 18:10:27 2014
@@ -127,7 +127,7 @@ public class VectorizedParquetInputForma
             assigners = VectorColumnAssignFactory.buildAssigners(outputBatch, writables);
           }
 
-          for(int i = 0; i < outputBatch.numCols; ++i) {
+          for(int i = 0; i < writables.length; ++i) {
             assigners[i].assignObjectValue(writables[i], outputBatch.size);
           }
           ++outputBatch.size;