You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2021/03/26 15:56:18 UTC

[GitHub] [tvm] tkonolige commented on a change in pull request #7750: [RUNTIME][WEB] Cleanup logging for web runtime.

tkonolige commented on a change in pull request #7750:
URL: https://github.com/apache/tvm/pull/7750#discussion_r602402636



##########
File path: include/tvm/runtime/logging.h
##########
@@ -55,6 +66,15 @@
 #define TVM_USE_LIBBACKTRACE 0
 #endif
 
+/*!
+ * \brief Whether or not customize the logging output.
+ *  If log customize is enabled, the user must implement
+ *  runtime::detail::LogFatalImpl and runtime::detail::LogMessageImpl

Review comment:
       ```suggestion
    *  tvm::runtime::detail::LogFatalImpl and tvm::runtime::detail::LogMessageImpl
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org