You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Jiang Yan Xu <ya...@jxu.me> on 2014/01/15 22:21:02 UTC
Re: Review Request 16742: Made StartMaster() wait for the master to realize
it is elected before returning it.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16742/
-----------------------------------------------------------
(Updated Jan. 15, 2014, 1:21 p.m.)
Review request for mesos, Benjamin Hindman, Ben Mahler, and Vinod Kone.
Changes
-------
Addressed comments.
Summary (updated)
-----------------
Made StartMaster() wait for the master to realize it is elected before returning it.
Bugs: MESOS-881
https://issues.apache.org/jira/browse/MESOS-881
Repository: mesos-git
Description
-------
See summary.
Diffs (updated)
-----
src/master/master.hpp 6e89149728ab8d5c3760a5dbc4d1ceafe873f731
src/tests/mesos.hpp b1239a653e515115a71e436c79b2d11db4a209f9
src/tests/mesos.cpp 5359394f45475803e05d281710139e8cbe7c7364
Diff: https://reviews.apache.org/r/16742/diff/
Testing
-------
make check.
Thanks,
Jiang Yan Xu
Re: Review Request 16742: Made StartMaster() wait for leader election result
before returning.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16742/#review31938
-----------------------------------------------------------
Ship it!
Ship It!
- Vinod Kone
On Jan. 15, 2014, 9:21 p.m., Jiang Yan Xu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16742/
> -----------------------------------------------------------
>
> (Updated Jan. 15, 2014, 9:21 p.m.)
>
>
> Review request for mesos, Benjamin Hindman, Ben Mahler, and Vinod Kone.
>
>
> Bugs: MESOS-881
> https://issues.apache.org/jira/browse/MESOS-881
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/master/master.hpp 6e89149728ab8d5c3760a5dbc4d1ceafe873f731
> src/tests/mesos.hpp b1239a653e515115a71e436c79b2d11db4a209f9
> src/tests/mesos.cpp 5359394f45475803e05d281710139e8cbe7c7364
>
> Diff: https://reviews.apache.org/r/16742/diff/
>
>
> Testing
> -------
>
> make check.
>
>
> Thanks,
>
> Jiang Yan Xu
>
>
Re: Review Request 16742: Made StartMaster() wait for leader election result
before returning.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16742/#review31945
-----------------------------------------------------------
committed. please mark as submitted.
- Vinod Kone
On Jan. 15, 2014, 9:21 p.m., Jiang Yan Xu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16742/
> -----------------------------------------------------------
>
> (Updated Jan. 15, 2014, 9:21 p.m.)
>
>
> Review request for mesos, Benjamin Hindman, Ben Mahler, and Vinod Kone.
>
>
> Bugs: MESOS-881
> https://issues.apache.org/jira/browse/MESOS-881
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/master/master.hpp 6e89149728ab8d5c3760a5dbc4d1ceafe873f731
> src/tests/mesos.hpp b1239a653e515115a71e436c79b2d11db4a209f9
> src/tests/mesos.cpp 5359394f45475803e05d281710139e8cbe7c7364
>
> Diff: https://reviews.apache.org/r/16742/diff/
>
>
> Testing
> -------
>
> make check.
>
>
> Thanks,
>
> Jiang Yan Xu
>
>
Re: Review Request 16742: Made StartMaster() wait for leader election result
before returning.
Posted by Jiang Yan Xu <ya...@jxu.me>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16742/
-----------------------------------------------------------
(Updated Jan. 15, 2014, 1:21 p.m.)
Review request for mesos, Benjamin Hindman, Ben Mahler, and Vinod Kone.
Summary (updated)
-----------------
Made StartMaster() wait for leader election result before returning.
Bugs: MESOS-881
https://issues.apache.org/jira/browse/MESOS-881
Repository: mesos-git
Description
-------
See summary.
Diffs
-----
src/master/master.hpp 6e89149728ab8d5c3760a5dbc4d1ceafe873f731
src/tests/mesos.hpp b1239a653e515115a71e436c79b2d11db4a209f9
src/tests/mesos.cpp 5359394f45475803e05d281710139e8cbe7c7364
Diff: https://reviews.apache.org/r/16742/diff/
Testing
-------
make check.
Thanks,
Jiang Yan Xu