You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2020/06/15 18:21:10 UTC

[GitHub] [kafka] chia7712 opened a new pull request #8874: HOTFIX: checkstyle error in ProcessorStateManager

chia7712 opened a new pull request #8874:
URL: https://github.com/apache/kafka/pull/8874


   ```
   [ant:checkstyle] [ERROR] /home/chia7712/kafka/streams/src/main/java/org/apache/kafka/streams/processor/internals/ProcessorStateManager.java:513:18: Variable 'oldType' should be declared final. [FinalLocalVariable]
   ```
   
   related to a0da6785a27b13be173762965402b55860ac5635
   
   ### Committer Checklist (excluded from commit message)
   - [ ] Verify design and implementation 
   - [ ] Verify test coverage and CI build status
   - [ ] Verify documentation (including upgrade notes)
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] guozhangwang commented on pull request #8874: HOTFIX: checkstyle error in ProcessorStateManager

Posted by GitBox <gi...@apache.org>.
guozhangwang commented on pull request #8874:
URL: https://github.com/apache/kafka/pull/8874#issuecomment-644329675


   To 2.6 as well.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] chia7712 commented on pull request #8874: HOTFIX: checkstyle error in ProcessorStateManager

Posted by GitBox <gi...@apache.org>.
chia7712 commented on pull request #8874:
URL: https://github.com/apache/kafka/pull/8874#issuecomment-644293179


   @cadonna @guozhangwang Could you take a look?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] mjsax commented on pull request #8874: HOTFIX: checkstyle error in ProcessorStateManager

Posted by GitBox <gi...@apache.org>.
mjsax commented on pull request #8874:
URL: https://github.com/apache/kafka/pull/8874#issuecomment-644328634


   Thanks! Was just about to do a hotfix PR myself.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] guozhangwang commented on pull request #8874: HOTFIX: checkstyle error in ProcessorStateManager

Posted by GitBox <gi...@apache.org>.
guozhangwang commented on pull request #8874:
URL: https://github.com/apache/kafka/pull/8874#issuecomment-644329167


   Ran checkstyle and spotbug locally and looks good.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] guozhangwang merged pull request #8874: HOTFIX: checkstyle error in ProcessorStateManager

Posted by GitBox <gi...@apache.org>.
guozhangwang merged pull request #8874:
URL: https://github.com/apache/kafka/pull/8874


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org