[jira] Commented: (TRANSACTION-28) NPE in FileResourceManager

["Henri Yandell (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/TRANSACTION-28?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12581818#action_12581818 ] 

Henri Yandell commented on TRANSACTION-28:
------------------------------------------

Not that that code can ever be evaluated. It starts with 'clean = true', then a bit later has 'if(!clean)'. The clean variable is always true.

So a bit of dead code.

> NPE in FileResourceManager
> --------------------------
>
>                 Key: TRANSACTION-28
>                 URL: https://issues.apache.org/jira/browse/TRANSACTION-28
>             Project: Commons Transaction
>          Issue Type: Bug
>         Environment: Fortify
>            Reporter: Henri Yandell
>
> If the cleanUp() method throws the Exception, it will lead to an NPE because 'cleanException' is null and the created Exception dereferences the passed in exception without protection. 
> Presumably ResourceManagerException's constructor needs to if-null protect the cause parameter.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.