You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/10/26 21:52:41 UTC

[GitHub] [airflow] uranusjr commented on a change in pull request #18981: Fix bug in Dataflow hook when no jobs are returned

uranusjr commented on a change in pull request #18981:
URL: https://github.com/apache/airflow/pull/18981#discussion_r736949240



##########
File path: tests/providers/google/cloud/hooks/test_dataflow.py
##########
@@ -1697,6 +1697,27 @@ def test_fetch_list_job_messages_responses(self):
         )
         assert result == ["response_1"]
 
+    def test_fetch_all_jobs_when_no_jobs_returned(self):
+        # fmt: off
+        (
+            self.mock_dataflow
+            .projects.return_value
+            .locations.return_value
+            .jobs.return_value
+            .list.return_value
+            .execute.return_value
+        ) = {}
+        # fmt: on

Review comment:
       It's not too long if the formatter says it's OK 🙂 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org