[GitHub] [dolphinscheduler] Amy0104 commented on a diff in pull request #9872: [Feature][Task Plugin] Add jupyter task plugin

[GitBox <gi...@apache.org>]

Amy0104 commented on code in PR #9872:
URL: https://github.com/apache/dolphinscheduler/pull/9872#discussion_r868853019


##########
dolphinscheduler-ui/src/views/projects/task/components/node/format-data.ts:
##########
@@ -528,6 +540,42 @@ export function formatModel(data: ITaskData) {
     params.zeppelinParagraphId = data.taskParams.zeppelinParagraphId
   }
 
+  if (data.taskParams?.condaEnvName) {
+    params.condaEnvName = data.taskParams.condaEnvName
+  }
+
+  if (data.taskParams?.inputNotePath) {
+    params.inputNotePath = data.taskParams.inputNotePath
+  }
+
+  if (data.taskParams?.outputNotePath) {
+    params.outputNotePath = data.taskParams.outputNotePath
+  }
+
+  if (data.taskParams?.parameters) {
+    params.parameters = data.taskParams.parameters
+  }
+
+  if (data.taskParams?.kernel) {
+    params.kernel = data.taskParams.kernel
+  }
+
+  if (data.taskParams?.engine) {
+    params.engine = data.taskParams.engine
+  }
+
+  if (data.taskParams?.executionTimeout) {
+    params.executionTimeout = data.taskParams.executionTimeout
+  }
+
+  if (data.taskParams?.startTimeout) {
+    params.startTimeout = data.taskParams.startTimeout
+  }
+
+  if (data.taskParams?.others) {
+    params.others = data.taskParams.others
+  }
+

Review Comment:
   If this is not a nested structure of the taskParams, there is no need to set the value one by one.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org