You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@calcite.apache.org by "Josh Elser (JIRA)" <ji...@apache.org> on 2015/08/11 06:54:45 UTC
[jira] [Commented] (CALCITE-839) Remove Jackson annotations from
POJO classes in Meta
[ https://issues.apache.org/jira/browse/CALCITE-839?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14681245#comment-14681245 ]
Josh Elser commented on CALCITE-839:
------------------------------------
I've started playing around with protobuf locally to see how this could be done. I hope to have a patch to show some intended direction sometime this week.
> Remove Jackson annotations from POJO classes in Meta
> ----------------------------------------------------
>
> Key: CALCITE-839
> URL: https://issues.apache.org/jira/browse/CALCITE-839
> Project: Calcite
> Issue Type: Bug
> Components: avatica
> Reporter: Julian Hyde
> Assignee: Julian Hyde
>
> The Meta interface contains several POJO classes that represent RPC requests or responses. Currently a few of those classes have Jackson annotations such as @JsonCreator, @JsonProperty to help Jackson serialize the POJO to JSON and de-serialize from JSON to the object.
> As [~ndimiduk] pointed out in http://mail-archives.apache.org/mod_mbox/incubator-calcite-dev/201503.mbox/%3CCANZa=GvKGD+BKJ4+eJMuO6iVhS+OkGSkG1VwDAZCy-ZijyyyPw@mail.gmail.com%3E these annotations are a "code smell" and should be removed. It makes it look as if Jackson is the only possible transport, which is not the case. We can continue to use Jackson as a transport, just specify the mappings elsewhere, not as annotations.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)