You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@aurora.apache.org by Zameer Manji <zm...@twopensource.com> on 2014/11/14 20:00:16 UTC
Review Request 28048: Fix task_util dependency and add it to all
target.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28048/
-----------------------------------------------------------
Review request for Aurora and Maxim Khutornenko.
Repository: aurora
Description
-------
Fix task_util dependency and add it to all target.
Diffs
-----
src/test/python/apache/aurora/client/api/BUILD b4f08c6192e6bf6b38665197e98db7235751ae86
Diff: https://reviews.apache.org/r/28048/diff/
Testing
-------
Before:
[tw-mbp-zmanji aurora (master)]$ ./pants src/test/python/apache/aurora/client/api:task_util
Build operating on top level addresses: set([BuildFileAddress(/Users/zmanji/workspace/aurora/src/test/python/apache/aurora/client/api/BUILD, task_util)])
======================================================== test session starts ========================================================
platform darwin -- Python 2.7.5 -- py-1.4.26 -- pytest-2.6.4
plugins: cov, timeout
collected 0 items / 1 errors
============================================================== ERRORS ===============================================================
____________________________ ERROR collecting src/test/python/apache/aurora/client/api/test_task_util.py ____________________________
src/test/python/apache/aurora/client/api/test_task_util.py:22: in <module>
from ..api.api_util import SchedulerThriftApiSpec
src/test/python/apache/aurora/client/api/api_util.py:1: in <module>
from apache.aurora.client.api.scheduler_client import SchedulerProxy
E ImportError: No module named scheduler_client
====================================================== 1 error in 0.18 seconds ======================================================
src.test.python.apache.aurora.client.api.task_util ..... FAILURE
After:
[tw-mbp-zmanji aurora (fix-task-util-test)]$ ./pants src/test/python/apache/aurora/client/api:task_util
Build operating on top level addresses: set([BuildFileAddress(/Users/zmanji/workspace/aurora/src/test/python/apache/aurora/client/api/BUILD, task_util)])
======================================================== test session starts ========================================================
platform darwin -- Python 2.7.5 -- py-1.4.26 -- pytest-2.6.4
plugins: cov, timeout
collected 2 items
src/test/python/apache/aurora/client/api/test_task_util.py ..
===================================================== 2 passed in 0.45 seconds ======================================================
src.test.python.apache.aurora.client.api.task_util ..... SUCCESS
Thanks,
Zameer Manji
Re: Review Request 28048: Fix task_util dependency and add it to all
target.
Posted by Maxim Khutornenko <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28048/#review61475
-----------------------------------------------------------
Ship it!
Ship It!
- Maxim Khutornenko
On Nov. 14, 2014, 7 p.m., Zameer Manji wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28048/
> -----------------------------------------------------------
>
> (Updated Nov. 14, 2014, 7 p.m.)
>
>
> Review request for Aurora and Maxim Khutornenko.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Fix task_util dependency and add it to all target.
>
>
> Diffs
> -----
>
> src/test/python/apache/aurora/client/api/BUILD b4f08c6192e6bf6b38665197e98db7235751ae86
>
> Diff: https://reviews.apache.org/r/28048/diff/
>
>
> Testing
> -------
>
> Before:
> [tw-mbp-zmanji aurora (master)]$ ./pants src/test/python/apache/aurora/client/api:task_util
> Build operating on top level addresses: set([BuildFileAddress(/Users/zmanji/workspace/aurora/src/test/python/apache/aurora/client/api/BUILD, task_util)])
> ======================================================== test session starts ========================================================
> platform darwin -- Python 2.7.5 -- py-1.4.26 -- pytest-2.6.4
> plugins: cov, timeout
> collected 0 items / 1 errors
>
> ============================================================== ERRORS ===============================================================
> ____________________________ ERROR collecting src/test/python/apache/aurora/client/api/test_task_util.py ____________________________
> src/test/python/apache/aurora/client/api/test_task_util.py:22: in <module>
> from ..api.api_util import SchedulerThriftApiSpec
> src/test/python/apache/aurora/client/api/api_util.py:1: in <module>
> from apache.aurora.client.api.scheduler_client import SchedulerProxy
> E ImportError: No module named scheduler_client
> ====================================================== 1 error in 0.18 seconds ======================================================
> src.test.python.apache.aurora.client.api.task_util ..... FAILURE
>
> After:
> [tw-mbp-zmanji aurora (fix-task-util-test)]$ ./pants src/test/python/apache/aurora/client/api:task_util
> Build operating on top level addresses: set([BuildFileAddress(/Users/zmanji/workspace/aurora/src/test/python/apache/aurora/client/api/BUILD, task_util)])
> ======================================================== test session starts ========================================================
> platform darwin -- Python 2.7.5 -- py-1.4.26 -- pytest-2.6.4
> plugins: cov, timeout
> collected 2 items
>
> src/test/python/apache/aurora/client/api/test_task_util.py ..
>
> ===================================================== 2 passed in 0.45 seconds ======================================================
> src.test.python.apache.aurora.client.api.task_util ..... SUCCESS
>
>
> Thanks,
>
> Zameer Manji
>
>
Re: Review Request 28048: Fix task_util dependency and add it to all
target.
Posted by Aurora ReviewBot <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28048/#review61482
-----------------------------------------------------------
Ship it!
Master (e9f135d) is green with this patch.
./build-support/jenkins/build.sh
I will refresh this build result if you post a review containing "@ReviewBot retry"
- Aurora ReviewBot
On Nov. 14, 2014, 7 p.m., Zameer Manji wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28048/
> -----------------------------------------------------------
>
> (Updated Nov. 14, 2014, 7 p.m.)
>
>
> Review request for Aurora and Maxim Khutornenko.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Fix task_util dependency and add it to all target.
>
>
> Diffs
> -----
>
> src/test/python/apache/aurora/client/api/BUILD b4f08c6192e6bf6b38665197e98db7235751ae86
>
> Diff: https://reviews.apache.org/r/28048/diff/
>
>
> Testing
> -------
>
> Before:
> [tw-mbp-zmanji aurora (master)]$ ./pants src/test/python/apache/aurora/client/api:task_util
> Build operating on top level addresses: set([BuildFileAddress(/Users/zmanji/workspace/aurora/src/test/python/apache/aurora/client/api/BUILD, task_util)])
> ======================================================== test session starts ========================================================
> platform darwin -- Python 2.7.5 -- py-1.4.26 -- pytest-2.6.4
> plugins: cov, timeout
> collected 0 items / 1 errors
>
> ============================================================== ERRORS ===============================================================
> ____________________________ ERROR collecting src/test/python/apache/aurora/client/api/test_task_util.py ____________________________
> src/test/python/apache/aurora/client/api/test_task_util.py:22: in <module>
> from ..api.api_util import SchedulerThriftApiSpec
> src/test/python/apache/aurora/client/api/api_util.py:1: in <module>
> from apache.aurora.client.api.scheduler_client import SchedulerProxy
> E ImportError: No module named scheduler_client
> ====================================================== 1 error in 0.18 seconds ======================================================
> src.test.python.apache.aurora.client.api.task_util ..... FAILURE
>
> After:
> [tw-mbp-zmanji aurora (fix-task-util-test)]$ ./pants src/test/python/apache/aurora/client/api:task_util
> Build operating on top level addresses: set([BuildFileAddress(/Users/zmanji/workspace/aurora/src/test/python/apache/aurora/client/api/BUILD, task_util)])
> ======================================================== test session starts ========================================================
> platform darwin -- Python 2.7.5 -- py-1.4.26 -- pytest-2.6.4
> plugins: cov, timeout
> collected 2 items
>
> src/test/python/apache/aurora/client/api/test_task_util.py ..
>
> ===================================================== 2 passed in 0.45 seconds ======================================================
> src.test.python.apache.aurora.client.api.task_util ..... SUCCESS
>
>
> Thanks,
>
> Zameer Manji
>
>