[GitHub] [incubator-yunikorn-k8shim] craigcondit edited a comment on pull request #320: [YUNIKORN-75] REST API for changing log level

[GitBox <gi...@apache.org>]

craigcondit edited a comment on pull request #320:
URL: https://github.com/apache/incubator-yunikorn-k8shim/pull/320#issuecomment-949786930


   @pbacsko, now that the newest core is being imported, the REST API has changed slightly. Can. you update this PR to fix the (now broken) e2e test in e2e/queue_quota_mgmt/queue_quota_mgmt_test.go? Otherwise, e2e tests will fail on any future PRs as well.
   
   I think this should do it:
   
   ```
   --- a/test/e2e/queue_quota_mgmt/queue_quota_mgmt_test.go
   +++ b/test/e2e/queue_quota_mgmt/queue_quota_mgmt_test.go
   @@ -102,9 +102,9 @@ var _ = Describe("", func() {
                           Ω(queueInfo["status"]).Should(Equal("Active"))
                           Ω(queueInfo["properties"]).Should(BeEmpty())
                           var capacities = queueInfo["capacities"].(map[string]interface{})
   -                       Ω(maxResource.ParseResourceUsageString(capacities["maxcapacity"].(string))).NotTo(HaveOccurred())
   -                       Ω(usedResource.ParseResourceUsageString(capacities["usedcapacity"].(string))).NotTo(HaveOccurred())
   -                       Ω(usedPerctResource.ParseResourceUsageString(capacities["absusedcapacity"].(string))).NotTo(HaveOccurred())
   +                       Ω(maxResource.ParseResourceUsageString(capacities["maxCapacity"].(string))).NotTo(HaveOccurred())
   +                       Ω(usedResource.ParseResourceUsageString(capacities["usedCapacity"].(string))).NotTo(HaveOccurred())
   +                       Ω(usedPerctResource.ParseResourceUsageString(capacities["absUsedCapacity"].(string))).NotTo(HaveOccurred())
    
                           By(fmt.Sprintf("App-%d: Verify max capacity on the queue is accurate", iter))
                           Ω(maxResource.GetVCPU()).Should(Equal(strconv.FormatInt(maxCPU, 10)))
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org