You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2018/09/10 20:42:28 UTC

[GitHub] aaronmarkham commented on a change in pull request #12490: Remove broken link regression test, fix broken links

aaronmarkham commented on a change in pull request #12490: Remove broken link regression test, fix broken links
URL: https://github.com/apache/incubator-mxnet/pull/12490#discussion_r216465452
 
 

 ##########
 File path: tests/nightly/broken_link_checker_test/test_broken_links.py
 ##########
 @@ -31,6 +31,7 @@ def prepare_link_test_result(command_output):
     # Whitelisted broken links patterns
     HTTP_403_REGEX = "(HTTP_403)"
     HTTP_401_REGEX = "(HTTP_401)"
+    HTTP_409_REGEX = "(HTTP_409)"
 
 Review comment:
   I think we need 301 and 303, as those are common redirect responses.
   Or just do 3xx if you can so it ignores any kind of redirection.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services