You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@brpc.apache.org by ji...@apache.org on 2024/05/26 16:28:55 UTC
(brpc) branch master updated: Add virtual destructors to MongoServiceAdaptor and SpanFilter (#2651)
This is an automated email from the ASF dual-hosted git repository.
jiashunzhu pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/brpc.git
The following commit(s) were added to refs/heads/master by this push:
new f81af914 Add virtual destructors to MongoServiceAdaptor and SpanFilter (#2651)
f81af914 is described below
commit f81af9143586cfb20ec101b9ba3575581d288d10
Author: Yonghui Zhao <zh...@gmail.com>
AuthorDate: Sun May 26 11:28:51 2024 -0500
Add virtual destructors to MongoServiceAdaptor and SpanFilter (#2651)
* Add virtual destructors to MongoServiceAdaptor and SpanFilter
* Virtual desctructor in SpanFiler and MongoServiceAdaptor
* Add virtual destructors to MongoServiceAdaptor and SpanFilte
---
src/brpc/mongo_service_adaptor.h | 2 ++
src/brpc/span.h | 1 +
2 files changed, 3 insertions(+)
diff --git a/src/brpc/mongo_service_adaptor.h b/src/brpc/mongo_service_adaptor.h
index 318e902e..d050fb6a 100644
--- a/src/brpc/mongo_service_adaptor.h
+++ b/src/brpc/mongo_service_adaptor.h
@@ -46,6 +46,8 @@ private:
class MongoServiceAdaptor {
public:
+ virtual ~MongoServiceAdaptor() = default;
+
// Make an error msg when the cntl fails. If cntl fails, we must send mongo client a msg not
// only to indicate the error, but also to finish the round trip.
virtual void SerializeError(int response_to, butil::IOBuf* out_buf) const = 0;
diff --git a/src/brpc/span.h b/src/brpc/span.h
index 44273405..1ef3d03c 100644
--- a/src/brpc/span.h
+++ b/src/brpc/span.h
@@ -206,6 +206,7 @@ void AnnotateSpan(const char* fmt, ...);
class SpanFilter {
public:
+ virtual ~SpanFilter() = default;
virtual bool Keep(const BriefSpan&) = 0;
};
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For additional commands, e-mail: dev-help@brpc.apache.org